[staabm]

get rid of some false-positives before we start auto-fixing

[Copilot]

🟡 Changes recommended

The recursive search incorrectly treats first-class callable creation as an executed parent call, suppressing the missing-call diagnostic even when parent setup never runs.

1 open issue

• Ignore first-class callables when detecting parent setup calls · New

What changed in this PR

This PR reduces false positives in ShouldCallParentMethodsRule by recognizing parent lifecycle calls nested inside control-flow statements.

Changes:

• Replaces the top-level scan with recursive traversal, excluding nested functions and classes.
• Adds fixtures for conditionals, try/catch/finally blocks, closures, and anonymous classes.
• Updates expected diagnostics for methods whose parent calls occur only in nested scopes.

File	Description
tests/​Rules/​PHPUnit/​ShouldCallParentMethodsRuleTest.php	Adds expected missing-parent-call diagnostics.
tests/​Rules/​PHPUnit/​data/​missing-parent-method-calls.php	Adds control-flow and nested-scope regression cases.
src/​Rules/​PHPUnit/​ShouldCallParentMethodsRule.php	Recursively detects parent calls while skipping nested scopes.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block approval of the parent lifecycle-call detection changes.

No open issues 🎉

1 resolved since last review

• Ignore first-class callables when detecting parent setup calls

_{Review effort: Balanced}