Repository navigation
Install Tally from its release branch, which brings CodSpeed's Valgrind - #7067
Merged
Merged
Conversation
release/1.x of phpstan/tally commits its build of CodSpeed's Valgrind fork and its tally_hooks extension for every supported PHP version, so the Benchmarks workflow no longer installs the CodSpeed CLI, builds instrument-hooks, or enables FFI. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d73a-bab0-7223-9245-50c2c00f22c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpstan/tally'srelease/1.xbranch commits Tally's build of CodSpeed's Valgrind fork (3.26.0-0codspeed13, Callgrind only) and itstally_hooksPHP extension for PHP 8.2–8.6, NTS and ZTS, on x86_64 and arm64. Tally starts that Valgrind with the optionscodspeed run --mode=simulationuses, and loads the extension into the counted worker itself.So the Benchmarks workflow no longer:
ext-ffi.The
composer.lockentry forphpstan/tallypoints todev-release/1.xat9830078. Packagist's p2 metadata for the package hadn't caught up yet, so I built the entry from Packagist's package data with Composer'sArrayDumper, the same wayLockerdoes.composer validatereports the lock as up to date, and the diff only touches that one entry.