Skip to content

Identity column support - #1448

Merged
dantownsend merged 18 commits into
masterfrom
identity-column
Oct 28, 2026
Merged

dantownsend merged 18 commits into
masterfrom
identity-column

Conversation

@dantownsend

Copy link
Copy Markdown
Member

No description provided.

@dantownsend

Copy link
Copy Markdown
Member Author

I think this is OK as a first step, so will merge in and build upon it.

@dantownsend
dantownsend merged commit 49a8875 into master Oct 28, 2026
41 checks passed
Comment thread piccolo/table.py
columns.insert(0, primary_key) # PK should be added first
default_columns.append(primary_key)

# Some databases (e.g. CockroachDB) won't even let us insert

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for this one!

return hash(self.__str__())


class Identity(Generated):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crystal clear for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants