fix: preserve 64-bit integers in Tarantool builds#2
Merged
Conversation
lua_pushinteger loses precision for values beyond double mantissa, so large JSON integers were rounded (e.g. 123456789012345678, 123456789012345680). Use luaL_pushint64/luaL_pushuint64 in TT_COMPAT builds to match tarantool json behavior: small ints as numbers, large ints as cdata (long/unsigned long).
alrsorokin
force-pushed
the
fix_long_precision
branch
4 times, most recently
from
1c96115 to
705d47b
Compare
alrsorokin
force-pushed
the
fix_long_precision
branch
from
705d47b to
08a415f
Compare
Kasen
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lua_pushinteger loses precision for values beyond double mantissa, so large JSON integers were rounded (e.g. 123456789012345678, 123456789012345680). Use luaL_pushint64/luaL_pushuint64 in TT_COMPAT builds to match tarantool json behavior: small ints as numbers, large ints as cdata (long/unsigned long).