Repository navigation
ci: fail the suite on hidden skips and run the engine suite in the PR gate - #197
Draft
luisleo526 wants to merge 16 commits into
Draft
luisleo526 wants to merge 16 commits into
luisleo526 wants to merge 16 commits into
Conversation
The first spot run proved the pattern list was incomplete: on a machine with no engine variables set at all the suite skips at the INCLUDE check, not at the library check, and 191 such skips were invisible to the gate. Added PINEFORGE_ENGINE_INCLUDE and "engine include / compiler unavailable" to the compile-environment patterns, and replaced the placeholder counts in the default profile with the numbers that run produced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen test gate now fails when the suite silently skips work it cannot do, and the engine suite runs in the pull-request gate in shards: a build job pins the engine and the corpus, the suite is split by a per-path hash into ten shards each with its own skip allowance, and the blocking gate job requires the build and every shard.
Carries #196's four
tests/gate-corpuscomment lines, cherry-picked unchanged (same subject, same four-line change, proved identical).Notes a reviewer should have:
engine_built_shard_<i>allowance profile is marked UNMEASURED: the first hosted run of each shard is expected to fail and print the exact rows to paste in.gate.yml(pull_request_target), so the newengine-build/engine-shardjobs are exercised withgh workflow run gate.yml --ref lv/ci-env-skips, not by opening this PR.🤖 Generated with Claude Code