Skip to content

Engine fixes for 1.15.0, batch 1 - #963

Closed
luisleo526 wants to merge 36 commits into
mainfrom
fix-batch-1
Closed

luisleo526 wants to merge 36 commits into
mainfrom
fix-batch-1

Conversation

@luisleo526

@luisleo526 luisleo526 commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Engine fixes for 1.15.0, first batch. Each change comes with a test that fails on v1.14.0; the full checks on this branch are running.

The user-visible changes are listed in CHANGELOG.md under "Unreleased (1.15.0)":

This pull request also carries tests and CI checks for these changes.

timezone_system_error_host_rows took the zone its EINVAL rows start
from from a time zone guard that had already ended. Since the guard
restores the caller's zone, that block did nothing, so with
TZ=America/New_York in the environment the injected failure never
fired and the row failed although the engine was right.

Each row now sets a different zone with the real setenv and tzset
before arming its injection, disarms the hook before recovery, and
restores the original TZ after each recovery read, also on unwind.
Every original assertion and diagnostic is kept.
The header defines PF_STREAM_ENGINE_LAYOUT_VERSION as 5u. docs/pages/abi-stability.md
said twice "ABI 5 and stream layout 4 stay fixed", and docs/pages/report-schema.md
said "ABI 5, stream layout 4, sink wire and fingerprint versions are unchanged".
The three sentences now say stream layout 5, the value the pages describe.

Refs #923
…ld scratch files (#925)

With --native-event-retention window, the runner probes the ledger's directory
for an unnamed spool file. When the probe failed it warned that the settled rows
stay in memory and cleared the scratch directory, and then built the window
accumulator from the empty string. An empty directory means the system
temporary directory, so the engine's equity-curve scratch file was written
under TMPDIR or /tmp, away from the ledger, with no message about it.

The accumulator is now built only when a scratch directory is left. When the
probe failed, the curve stays in memory and the runner says so, as it already
does for a ledger on a memory filesystem.

The new case restarts a ledger whose SQLite files stay open, removes write
permission on the ledger's directory so that the probe fails, points TMPDIR at
a disk-backed directory, and checks that the runner holds no report scratch
file there (the engine's own command journal is an unnamed file in TMPDIR in
every run and is expected) and that the curve warning is printed once.

Refs #925
…ne layout stamp (#926)

--native-event-retention window keeps the kernel's event window only for a
module that declares the current engine layout stamp; for any other module the
whole event record is kept. The ledger's checkpoint storage did not follow: it
streamed a large checkpoint into a BLOB whenever the option said window, so an
unstamped module ran with the whole event record and the streamed storage, and
nothing said that the option had not been applied.

Both decisions now come from one condition. An unstamped module keeps the whole
event record and the TEXT checkpoint storage, and the runner prints one warning
at startup that the option is not applied to this module. The README names the
condition and the warning.

The new case runs a stamped and an unstamped module with the same option and
more than one MiB of checkpoint: the stamped module stores a BLOB and prints no
warning, the unstamped module stores TEXT and prints the warning once.

Refs #926
With --native-event-retention window the runner writes a report checkpoint
above 1 MiB into its row in pieces, as a BLOB, so that its memory does not grow
with the size of the report. That held only above cursor 512: a checkpoint at
cursor 512 or below was built as one JSON tree, serialized into one string and
stored as TEXT, whatever its size. In a measurement with 512 batched inputs the
checkpoint was 26.7 MiB and the tree raised the runner's peak resident memory
by 441 MiB, about 17 times the payload; the streamed checkpoint at cursor 1024
raised it by 0.6 MiB.

A run that streams large checkpoints now folds every checkpoint through the
spooled arrays, which write the same bytes, so a payload above 1 MiB is
streamed at any cursor. A run without the option is unchanged: it still builds
the tree up to cursor 512 and stores the payload as TEXT.

The new case runs 512 batched inputs three times: with the option and no
checkpoint, with the option and a checkpoint at cursor 512, and without the
option and a checkpoint at cursor 512. It checks that the checkpoint is a BLOB
with the option and TEXT without it, that both hold the same bytes and hash,
and that the checkpoint raises the peak resident memory by less than its own
size.

Refs #961
… scratch directory

The runner README and the memory guide now say that a run with
--native-event-retention window folds every report checkpoint through the
spooled arrays and writes a payload above 1 MiB into its row in pieces, as a
BLOB, at any cursor. Without the option the tree is still built up to cursor
512 and the payload is stored as TEXT.

They also say where the engine's own scratch files are. The spilled part of its
trade ledger and its command journals, among others, are unlinked files in
TMPDIR (else /tmp), not in the ledger's directory, and --max-ledger-bytes does
not count them, so TMPDIR needs a disk-backed directory with room for them.

The code line citations that the preceding changes moved are refreshed: the
Ledger and checkpoint functions in store.cpp, the post-replay call in main.cpp,
report_memory in the runner test, and the README lines that the source-bounds
inventory cites.

Refs #961
…#927)

A ledger that holds report inputs but no report checkpoint is folded once when
the ledger is opened, and that fold can write spool files. The runner installed
its spool-failure handler only after the ledger was opened, but a spool failure
sets the run's one-warning flag whether or not a handler is installed. A
failure inside the startup fold therefore printed nothing and used up the
warning, so every later failure of the run, including the explicit probe, was
silent too.

The handler and the test file-size limit are now set before the ledger is
opened, so the first failure prints the existing warning once. The probe takes
the same one-warning flag before it prints, so a run whose startup fold and
probe fail for the same reason still prints one warning.

The new case restarts copies of a ledger with 513 report inputs and no
checkpoint: one without a cap, one with the spool file size capped so that the
startup fold reaches a write refusal, and one with the same cap and a status
file in a missing directory, which stops the run right after the ledger is
opened so that only the startup fold can have printed. The capped restart
prints the write warning once and writes the same report bytes as the uncapped
one.

Refs #927
…o create it (#928)

On a filesystem without unnamed files the report spool is created with a name
and unlinked at once. The result of the unlink was ignored, so a refused unlink
left the named file in the ledger's directory, holding the settled report
rows, after the run, and nothing said so.

A failed unlink now closes the descriptor, tries once more to remove the file
and throws the same error as a failed creation, so the caller's existing
fallback applies: the rows stay in memory and the run warns once.

The new test builds the spool in a temporary directory with the open and unlink
calls of the test binary wrapped at link time. The unnamed-file open is refused
so that the named path is used, and the first unlink of the spool's name is
refused. It checks that the constructor throws the creation error and that the
directory holds no named spool file, then that an ordinary construction leaves
no name either.

Refs #928
…ing it silently (#946)

atomic_json_file writes a service file to <name>.new.XXXXXX and installs it with
link() (a control request, which must not replace an existing file) or with
rename(). After a successful link() it ignored the result of unlink() on the
temporary name, and its failure path ignored it too, so a refused unlink left
<id>.request.json.new.XXXXXX beside the request, or a temporary file after a
failed write or install, with no message.

A refused unlink of the temporary name is now retried once and reported once on
stderr, naming the file. An install that succeeded stays a success, and a failed
write or install still raises its own error. After a rename the temporary name
is gone and nothing is unlinked.

The new test wraps unlink at link time in its own binary (no production seam and
no special permissions) and runs the writer in four cases: a link whose cleanup
is always refused, one refusal followed by a successful retry, a link onto an
existing target with the cleanup working and refused, and a rename.

Refs #946
The row for the service file writer's unlink test named its source as
../tests/test_service_unlink_failure.cpp. scripts/check_private_fixture_reads.py
walks every registered row and refuses a source whose path has a .. part
("names a source outside the tree"), so the test_private_fixture_reads row and
its controls failed on the tree with the new test. Every other row of
runner/CMakeLists.txt names its source as ${PROJECT_SOURCE_DIR}/tests/<name>.cpp;
this one now does too, and the sweep and its controls pass.
detect_timeframe subtracts neighbouring timestamps; a gap wider than the
signed range must still count as an increasing gap, and a decreasing pair
must still be ignored.
…frame

Compare neighbouring timestamps before subtracting, and subtract as
unsigned values so the exact positive gap is kept even across zero. Results
for ordinary gaps are unchanged.
Format 1706746029000 with the UTC zone while the process TZ is
America/New_York; %s must stay 1706746029.
strftime reads the broken-down UTC fields back through mktime for %s, which
uses the process timezone. Substitute the Unix second for an unquoted plain
%s before calling it.
#718)

In a split session the fixed-timeframe period that contains the reopening
starts before the session resumes, so its nominal open and its eligible open
differ. While a row at the eligible open is the latest accepted input the
lookup must resolve it, and the next period must stay unresolved until its
own row is accepted.
…t lookup (#718)

The lookup refused every timestamp after the latest accepted input's nominal
open before it compared the eligible open, so the clipped opening of a
split-session period never resolved. Check the admitted labels of the latest
input first, then refuse later timestamps.
Cover the smallest minute count that overflows (35791395), a negative minute
count, week counts from 3551, negative day counts from -24856 and tf_ratio
with an overflowing target, each beside a boundary control that fits.
tf_to_seconds multiplied the parsed count by the unit length in int, so a
minute count from 35791395 up, a week count from 3551 up and a day count
from -24856 down overflowed into a wrong length; for example 71582789
minutes read as 44 seconds.

Multiply in 64 bits. A minute count, or a negative count, whose seconds do
not fit now raises the refusal the parser already uses for a count past int.
A week count past the limit is calendar-only, as a day count past it already
is, and tf_ratio keeps passing equal calendar-only week literals through.
Every input that did not overflow gives the same result.

Add the changelog entry and shift the line citations in two pages by the 18
lines this change adds to src/timeframe.cpp.
… engine layout stamp

With --native-event-retention window, a module that does not declare the
current engine layout stamp does not get the windowed behaviour: the runner
prints the warning that the option is not applied, and a checkpoint of such a
run is built the way a run without the option builds it (the change for #926).
Three README sentences still described the windowed behaviour for every module.
They now say that it needs the stamp:

- "Above it, and at every cursor with that option, preparation folds every
  report row from cursor 0 through spooled arrays" now reads "...with that
  option on a module that has the engine layout stamp...".
- "With `--native-event-retention window`, a payload above 1 MiB is hashed and
  written into its row in pieces, at any cursor" now reads "...on a module that
  has the engine layout stamp...", and the sentence after it, "Without that
  option the payload is built as one string and stored as TEXT", now also
  covers a module without the stamp.
- "With `--native-event-retention window`, a checkpoint above 1 MiB is admitted
  whole" now reads "...on a module that has the engine layout stamp...".

Only these sentences change, in place; no line is added or removed.
…our changes since 1.14.0

The first section of the changelog still read "Unreleased" although it holds
the 1.14.0 entries, and the 1.13.0 heading had no date. The first of those two
headings now reads "1.14.0 — 2026-11-20" and the second "1.13.0 — 2026-11-18",
the dates of the commits the two release tags point to, in the form the older
headings use. A new "Unreleased (1.15.0)" section above them holds the entries
of the changes since the tag: the stream layout number in three documentation
sentences, the runner's spool and unlink handling for the windowed event
retention (the equity scratch file, the layout stamp warning, the report spool
warning, the failed unlink of the fallback spool file and of the service file
writer's temporary file), the checkpoint that is now folded at any cursor with
the measured memory before and after, and the calendar exporter's check before
it writes its destination. The entries that other fixes already added at the
top of the old section, and the series-length ta.sma entry that landed among
the 1.14.0 entries, belong to the new section and sit there. No entry of the
1.14.0 section is edited.
The design notes and pages cite lines of docker/run_failure_codes.json,
include/pineforge/ta.hpp and runner/report_spool.hpp. The changes folded here
add lines to those files above the cited places, so the citations after those
lines moved: 12 citations on 10 lines in 3 documents. Some are re-pointed to
the same symbols by scripts/check_doc_anchors.py --fix. The others name a symbol
that occurs on several lines, which the checker leaves to the author:
scripts/reanchor_doc_citations.py carried each of them to the line its symbol
has in this tree, using the parent tree as the reference and checking that the
new line holds the symbol. No text other than the line numbers changes, and the
checker reports every anchor resolved, 2376 of 2376.
@luisleo526

Copy link
Copy Markdown
Collaborator Author

Superseded by #964 (same fixes; one commit message now names the documentation sentences it removes, and the CI source manifest is updated).

@luisleo526 luisleo526 closed this Nov 21, 2026
@luisleo526
luisleo526 deleted the fix-batch-1 branch November 21, 2026 05:48

@graphify-labs graphify-labs Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify code review View in Graphify

Review completed · 92626411bd41

Note

Merge confidence: 5/5 · Nothing blocking · 13 possible issues to check · 🟠 High impact
13 possible issues not confirmed

The revision changes report checkpoint storage and temporary-file handling, and updates EMA/SMA arithmetic, timeframe conversion, and native interval lookup.

Full summary

The revision changes report checkpoint storage and temporary-file handling, and updates EMA/SMA arithmetic, timeframe conversion, and native interval lookup. It also changes how time formatting handles Unix-second directives and how pre-bar errors are described.

No confirmed issues. We found 13 possible issues we couldn't confirm; see below.

Not confirmed (13 possible issues)

Leads worth a look; we didn't double-check these. They don't change the score.

Not confirmed · Test waits forever if the runner stays alive but never reports readiness Inspect source

Detailed review · not confirmed

wait_ready loops with no deadline, so a runner that hangs before writing a ready status blocks the test until the outer harness kills it.

The loop exits only when the process is reaped (line 111) or the status JSON reports ready (line 115). Nothing bounds the elapsed time, and errors() is never included in a timeout message.

  • Whether the outer harness imposes its own timeout was not visible in the provided code.

  • Found by the per-file sweep; not double-checked.

Not confirmed · Pipe for held stdin is created without close-on-exec, so later runners can inherit its write end Inspect source

Detailed review · not confirmed

Runner creates the stdin pipe with ::pipe and no O_CLOEXEC. Any runner forked while a held-input runner is still alive inherits that write end, so the held runner never sees EOF on stdin.

pipe on Linux sets no close-on-exec flag by default. finish (line 128) closes only the parent's copy, so any child forked earlier or later that still has the fd keeps the pipe open. The problem is latent here, not triggered by the current sequence.

  • Only the current call order in recovery_spool_warning was checked; no concurrent runner use was found in this file.

  • Found by the per-file sweep; not double-checked.

Not confirmed · The unlink stub matches .new. anywhere in the full path, so directory names can trigger refusals and inflate unlink counts Inspect source

Detailed review · not confirmed

The test's unlink stub checks whether the whole path contains .new., not just the temporary file's name. Any unlink under a directory whose path contains that text is counted and can be refused, so the retry counts asserted by the tests may not describe the service's behavior.

Line 31 runs std::strstr on the full name argument. Lines 32 to 36 count and refuse every match. The expected counts at lines 117, 131, 160 and 164 assume that only the service's temporary file matches. The directory at line 51 comes from fs::temp_directory_path, so its prefix is outside the test's control.

  • Does not check whether the service unlinks paths outside the temporary file pattern

  • Assumes the --wrap=unlink link setting applies to the service's unlink calls only

  • Found by the per-file sweep; not double-checked.

Not confirmed · Unlink failure injection only catches plain unlink calls, so a spool that removes files another way never sees the refusal and the test fa Inspect source

Detailed review · not confirmed

The test forces a failed cleanup by overriding unlink only. If ReportSpool removes its file with unlinkat or std::filesystem::remove, the override never runs, refused_unlinks stays at 0, and the check at line 93 fails even though the code under test may be correct.

__wrap_unlink is reached only through the linker --wrap=unlink mechanism, which redirects direct undefined references to unlink. Lines 85-88 depend on the spool's constructor reaching that path, and lines 93-94 assert on refused_unlinks. The shown test does not reveal how ../runner/report_spool.hpp removes files, so the dependency is unverified.

  • The implementation in ../runner/report_spool.hpp and its build flags were not in the inspected scope

  • Whether the spool calls unlink directly or through unlinkat or std::filesystem was not checked

  • Found by the per-file sweep; not double-checked.

Not confirmed · Open failure injection only intercepts open, so the O_TMPFILE fallback may be skipped if the spool calls open64 or openat Inspect source

Detailed review · not confirmed

The test makes open fail with EOPNOTSUPP for O_TMPFILE to force the mkstemp fallback. If the spool opens files through open64, openat, or another variant, that call is not intercepted, and the test may not exercise the path its comment describes.

Lines 53-59 and the comment at line 54 assume every O_TMPFILE attempt reaches __wrap_open. Only the open symbol is wrapped, and the file does not show whether ReportSpool calls that symbol directly.

  • The O_TMPFILE call site and open variant used by ../runner/report_spool.hpp were not inspected

  • Platforms or build options where the spool uses openat or open64 were not checked

  • Found by the per-file sweep; not double-checked.

Not confirmed · Test expects detect_timeframe to return "1" for a 300000 ms (5-minute) spacing, which looks inconsistent with its own data Inspect source

Detailed review · not confirmed

The 2-bar slice starting at the second bar has a spacing of 300000 ms, which is 5 minutes, but the test expects the 1-minute timeframe "1".

The bars are latest, earliest+300000 with earliest at INT64_MIN and latest at INT64_MAX. Their difference wraps to about 300001 ms, which is near 5 minutes, not 60000 ms. The expected value "1" does not follow from the spacing shown. The test does not explain why.

  • The implementation of detect_timeframe is not in the inspected scope, so its handling of the wrapped difference is unknown.

  • Found by the per-file sweep; not double-checked.

Not confirmed · Comment about the two increasing gaps does not match the four-bar input, which has three gaps Inspect source

Detailed review · not confirmed

The comment on the four-bar assertion describes two increasing gaps, but the input gives three consecutive differences, and the first is an overflowing wrap.

The bars are earliest, latest, earliest+300000, earliest+600000. Consecutive differences are the wrapped latest-earliest, a wrapped negative value, and 300000. The comment does not describe this.

  • Whether the expected "W" result follows from the upper-median rule is not checked because detect_timeframe is not in scope.

  • Found by the per-file sweep; not double-checked.

Not confirmed · The test's midnight anchor is kZones[0].t0, which the file describes as a session open, so the session times may not start at midnight Inspect source

Detailed review · not confirmed

midnight is set to kZones[0].t0, but the existing comment on session_bars describes zone.t0 as the session open. The test then builds both session start times as midnight + offset, so its 09:30 and 09:00 starts only hold if kZones[0].t0 is exactly UTC midnight.

Line 336 names the value midnight and assigns it kZones[0].t0. Lines 338 and 339 then compute session starts as midnight + (9 * 60 + 30) * kMinute and midnight + 9 * 60 * kMinute. The comment at lines 292-293 says zone.t0 is the session open, not a day boundary. Lines 348, 352 and 353 depend on session_day_at and day->origin_ms describing that same day, so a non-midnight anchor makes the expected reopen and next-hour values inconsistent with the session strings.

  • The value of kZones[0].t0 is not visible in this file range, so it is unknown whether it is actually UTC midnight.

  • The definition of day->origin_ms in the calendar code is not shown.

  • Found by the per-file sweep; not double-checked.

Not confirmed · A nonfinite or overflowing sum leaves NaN or infinity stored in the window's partials, so the window can stay broken after the value leaves Inspect source

Detailed review · not confirmed

When expand_window_sum returns false, it has already written NaN or infinite values into the partial storage and updated parts. Any later sums built on that storage stay nonfinite.

Lines 26-28 compute high and low with no finiteness check, so a NaN or infinite x is stored as a partial. Line 31 then saves the final x, and line 33 only returns isfinite(x). The comment on line 19 says false means a nonfinite source or overflow, but it does not say the partials are reset. The caller code is not in this file, so it is unclear whether it discards the storage on false.

  • The calling window code is not shown, so it is unknown whether it resets or discards the partials after a false return.

  • Removal from a window is not shown, so it is unknown whether a poisoned state can be recovered.

  • Found by the per-file sweep; not double-checked.

Not confirmed · A run without --native-config that sets --native-event-retention gets a warning blaming a missing engine layout stamp Inspect source

Detailed review · not confirmed

The warning fires for any run that sets --native-event-retention without a current engine layout, even when no native config is present. In that case the option is ignored for a different reason, and the message names the wrong cause.

Line 1159 checks only c.native_event_retention && !strategy.has_current_engine_layout, not c.native.present. Line 1155 already requires c.native.present before applying the retention, so the ignored-option case with no native config is reported using the layout message.

  • Not checked: whether the option is also rejected earlier in argument parsing when no native config is given.

  • Found by the per-file sweep; not double-checked.

3 more possible issues are available in Graphify.

What this review covered
  • We didn't review 15 files that aren't source code, such as docs, config, images, or generated or third-party code.
  • One review pass used all of its turns for reading code, so it reported from what it had already read.
  • 38 of 38 changed files inspected. This is scope, not a correctness guarantee.
Code graph and static checks · 5003 functions depend on this change

Impact & health

Impact — 5003 functions depend on the 3807 functions this change touches.

Health — this change adds coupling hotspots:

  • worse: tf_change() — 28 callers, 5 callees
  • worse: wait_ready() — 18 callers, 5 callees
  • worse: crosses_boundary() — 8 callers, 8 callees
  • worse: str_tostring() — 8 callers, 7 callees
  • worse: native_run_spec_digest() — 17 callers, 3 callees
  • worse: build_native_day_partition() — 9 callers, 5 callees
  • worse: timeframe_time_close() — 2 callers, 12 callees
  • worse: timeframe_time() — 2 callers, 9 callees
  • …and 12 more — each is listed as a finding

Formal checks — 5003 functions this change can affect weren't formally checked in this review. Formal checks are informational only.

Gate & verification

✅ PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 4914 function(s) in the blast radius were not formally verified this run

Test selection

1468 of 1468 test file(s) selected (100%) via static blast radius.

Escalated to a full run for safety (noncode-change, uncovered-code) — the selection is not trustworthy on its own (see below). CI should run the whole suite.

  • benchmarks/tests/test_aggregate.py — full-run-safety
  • benchmarks/tests/test_check_provenance.py — full-run-safety
  • benchmarks/tests/test_compare.py — full-run-safety
  • benchmarks/tests/test_public_names.py — full-run-safety
  • benchmarks/tests/test_run_all.py — full-run-safety
  • benchmarks/tests/test_run_strategy_feeds.py — full-run-safety
  • docker/pineforge_sink_finalize_test.py — full-run-safety
  • docker/pineforge_sink_replay_rq_test.py — full-run-safety
  • docker/pineforge_sink_replay_test.py — full-run-safety
  • docker/pineforge_sink_to_json_test.py — full-run-safety
  • docker/quota_columns_test.py — full-run-safety
  • docker/quota_convert_test.py — full-run-safety
  • docker/quota_finalize_test.py — full-run-safety
  • docker/replay_rq_engine_test.py — full-run-safety
  • docker/run_json_artifact_window_test.py — full-run-safety
  • docker/run_json_bin_test.py — full-run-safety
  • docker/run_json_bounded_transport_test.py — full-run-safety
  • docker/run_json_bulk_equity_fuzz_test.py — full-run-safety
  • docker/run_json_bulk_equity_test.py — full-run-safety
  • docker/run_json_codes_test.py — full-run-safety
  • docker/run_json_converter_metadata_test.py — full-run-safety
  • docker/run_json_converter_session_test.py — full-run-safety
  • docker/run_json_diagnostics_test.py — full-run-safety
  • docker/run_json_equity_scan_test.py — full-run-safety
  • docker/run_json_fused_test.py — full-run-safety
  • docker/run_json_harnesses_test.py — full-run-safety
  • docker/run_json_metrics_only_test.py — full-run-safety
  • docker/run_json_misc2_test.py — full-run-safety
  • docker/run_json_misc_test.py — full-run-safety
  • docker/run_json_pfbar_test.py — full-run-safety
  • docker/run_json_provenance_test.py — full-run-safety
  • docker/run_json_quota_supervisor_test.py — full-run-safety
  • docker/run_json_replay_test.py — full-run-safety
  • docker/run_json_selected_sink_test.py — full-run-safety
  • docker/run_json_sink_lexical_test.py — full-run-safety
  • docker/run_json_sink_summary_test.py — full-run-safety
  • docker/run_json_sink_test.py — full-run-safety
  • docker/run_json_sink_vectors_test.py — full-run-safety
  • docker/run_json_spool_work_test.py — full-run-safety
  • docker/run_json_stringio_test.py — full-run-safety
  • docker/run_json_symbol_feeds_test.py — full-run-safety
  • docker/run_json_syminfo_test.py — full-run-safety
  • docker/run_json_trade_scan_test.py — full-run-safety
  • docker/run_json_window_budget_test.py — full-run-safety
  • docker/run_json_wrapper_work_test.py — full-run-safety
  • include/pineforge/native_run_spec.hpp — full-run-safety
  • scripts/derive_corpus_feeds_self_test.py — full-run-safety
  • scripts/fingerprint_self_test.py — full-run-safety
  • scripts/run_corpus_self_test.py — full-run-safety
  • scripts/test_abi_receipt_skips.py — full-run-safety
  • … and 1418 more

⚠️ non-code file(s) changed (CHANGELOG.md, ci/cr150-source-bounds.yaml, docker/run_failure_codes.json, docker/run_failure_codes_diff.json, docs/adr/0001-kernel-adapter-boundary.md …) → running the full suite for safety (a code graph can't see config/fixture/data deps)

⚠️ changed code file(s) with no mapped test (CHANGELOG.md, docs/adr/0001-kernel-adapter-boundary.md, docs/design/BARS-BIN-INPUT.md, docs/live-ledger-budget.md, docs/native-refactor-progress.md …) — a coverage gap or a missing link — running the full suite rather than only the selected tests

Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.

Every flagged function

  • tf_change() in src/timeframe.cpp:1163 · 28 callers, 5 callees: 28 callers depend on it (afferent coupling)
  • wait_ready() in tests/test_native_live_report_cli.cpp:284 · 18 callers, 5 callees: 18 callers depend on it (afferent coupling)
  • native_run_spec_digest() in src/native_execution_consumer.cpp:14961 · 17 callers, 3 callees: 17 callers depend on it (afferent coupling)
  • build_native_day_partition() in src/timeframe.cpp:879 · 9 callers, 5 callees: 9 callers depend on it (afferent coupling)
  • crosses_boundary() in src/timeframe.cpp:1101 · 8 callers, 8 callees: fans out to 8 callees (efferent coupling); 8 callers depend on it (afferent coupling)
  • str_tostring() in src/str_utils.cpp:463 · 8 callers, 7 callees: fans out to 7 callees (efferent coupling); 8 callers depend on it (afferent coupling)
  • timeframe_time_close() in src/session_time.cpp:1896 · 2 callers, 12 callees: fans out to 12 callees (efferent coupling)
  • spool_probe_failure_keeps_curve_resident() in tests/test_native_live_report_cli.cpp:1632 · 1 callers, 12 callees: fans out to 12 callees (efferent coupling)
  • native_report_json() in runner/report.hpp:108 · 3 callers, 6 callees: fans out to 6 callees (efferent coupling)
  • session_in_postmarket() in src/session_time.cpp:1679 · 3 callers, 4 callees: high coupling complexity (Ca·Ce = 12)
  • session_in_premarket() in src/session_time.cpp:1644 · 3 callers, 4 callees: high coupling complexity (Ca·Ce = 12)
  • timeframe_time() in src/session_time.cpp:1848 · 2 callers, 9 callees: fans out to 9 callees (efferent coupling)
  • window_checkpoint_storage() in tests/test_native_live_report_cli.cpp:1488 · 1 callers, 10 callees: fans out to 10 callees (efferent coupling)
  • window_checkpoint_streams_at_the_tree_cursor() in tests/test_native_live_report_cli.cpp:1541 · 1 callers, 10 callees: fans out to 10 callees (efferent coupling)
  • recovery_spool_warning() in tests/test_native_live_recovery_spool_warning.cpp:190 · 1 callers, 9 callees: fans out to 9 callees (efferent coupling)
  • check_existing_target() in tests/test_service_unlink_failure.cpp:134 · 1 callers, 8 callees: fans out to 8 callees (efferent coupling)
  • number_style_text() in src/str_utils.cpp:165 · 1 callers, 7 callees: fans out to 7 callees (efferent coupling)
  • link_with_persistent_refusal() in tests/test_service_unlink_failure.cpp:105 · 0 callers, 7 callees: fans out to 7 callees (efferent coupling)
  • link_with_one_refusal() in tests/test_service_unlink_failure.cpp:120 · 0 callers, 6 callees: fans out to 6 callees (efferent coupling)
  • rename_does_not_unlink() in tests/test_service_unlink_failure.cpp:173 · 0 callers, 6 callees: fans out to 6 callees (efferent coupling)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant