cloud: clarify IMPORT INTO wildcard path matching - #23488
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesfileLocation wildcard documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized documentation update clarifies wildcard path behavior and preserves platform-specific guidance; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@GMHDBJD PTAL |
6674b29 to
ba96fab
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
What is changed, added or deleted? (Required)
This PR corrects the TiDB Cloud guidance for wildcard paths in
IMPORT INTO:/-separated component and does not provide arbitrary-depth recursive matching.s3://<bucket-name>/dir/subdir*/*.csvas a fixed-depth S3 example.The previous Cloud wording incorrectly limited wildcards to file names. TiDB now supports component-aware patterns such as
dir/subdir*/*.csv, while still requiring each wildcard to remain within one path component.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Validation
./scripts/markdownlint sql-statements/sql-statement-import-into.mdpython3 scripts/file-format-lint.py sql-statements/sql-statement-import-into.mdpython3 scripts/check-manual-line-breaks.py sql-statements/sql-statement-import-into.mdgo test -tags=intest,deadlock ./pkg/importsdk -run 'Test(ValidatePattern|GenerateWildcardPath)$' -count=1in the TiDB repository. The tests verify that the import SDK accepts and generatesdir/subdir*/*.csv.IMPORT INTOsmoke test against a local TiDB cluster and an S3-compatible MinIO endpoint usings3://import-smoke/fixture/dir/subdir*/*.csv. The job finished with four imported rows from two matching directories. Decoy objects in a different directory, one level deeper, with a non-CSV extension, and without the final file component were all excluded.The direct SQL smoke test validates S3 path matching in the TiDB engine. It does not claim an end-to-end test against a live TiDB Cloud cluster or the Aurora/RDS Parquet workflow.
Do your changes match any of the following descriptions?
Summary by CodeRabbit
.csvfiles within subdirectories.