Skip to content

i18n(ja): restore English admonition labels - #23516

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-note-label-normalization-2026-08-13
Open

i18n(ja): restore English admonition labels#23516
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-note-label-normalization-2026-08-13

Conversation

@yahonda

@yahonda yahonda commented Aug 13, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Machine translation left 95 admonition labels (注記/警告/ヒント) in Japanese instead of the English Note/Warning/Tip that the site's renderer keys on to produce a styled callout box — the Japanese-labeled versions render as plain bold text instead of a real callout. Restored each to match its corresponding English label's exact colon form (inside/outside/none) at the same position in the source, verified by pairing every JA and EN admonition occurrence in each file positionally and confirming word + count match with zero mismatches before applying any change.

resources/doc-templates/ (9 of the 95 sites) is intentionally excluded per an earlier scoping decision and left untouched — 86 sites across 38 real doc pages are fixed.

Also fixed 2 related false-friend defects found while auditing every remaining 注記/警告/ヒント occurrence in the corpus:

  • tidb-cloud/monitor-alert-email.md: a link to the "Alert" page had been mistranslated as 警告 ("a warning"), not the page name.
  • optimizer-fix-controls.md: a cross-reference to "the Note in [Explain Statements Using Index Merge]" had 注記 in place of the literal English label the referenced page's own admonition uses.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign icemap for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0669426f-adef-4ae3-86e4-b9b620610157

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2026
@yahonda
yahonda marked this pull request as ready for review August 13, 2026 02:30
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2026
@yahonda
yahonda force-pushed the fix-note-label-normalization-2026-08-13 branch from c0a92a2 to 4e6ec03 Compare August 13, 2026 02:30
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 13, 2026
Machine translation left 95 admonition labels (注記/警告/ヒント) in
Japanese across 42 files instead of the English Note/Warning/Tip that
the site's renderer keys on to produce a styled callout box -- the
Japanese-labeled versions render as plain bold text instead. Restored
each to match its corresponding English label's exact colon form
(inside/outside/none) at the same position in the source, verified by
pairing every JA and EN admonition occurrence in each file positionally
and confirming word + count match with zero mismatches before applying
any change.

resources/doc-templates/ (9 of the 95 sites) is intentionally excluded
per an earlier scoping decision and left untouched; 86 sites across
38 real doc pages are fixed.

Also fixed 2 related false-friend defects found while auditing every
remaining 注記/警告/ヒント occurrence in the corpus:
- tidb-cloud/monitor-alert-email.md: a link to the "Alert" page had
  been mistranslated as 警告 (a "warning"), not the page name.
- optimizer-fix-controls.md: a cross-reference to "the **Note** in
  [Explain Statements Using Index Merge]" had 注記 in place of the
  literal English label the referenced page's own admonition uses.
@yahonda
yahonda force-pushed the fix-note-label-normalization-2026-08-13 branch from 4e6ec03 to 18236db Compare August 13, 2026 05:06
@CLAassistant

CLAassistant commented Aug 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants