docs: fix tidb_server_memory_limit unit description (release-8.0) - #23662
docs: fix tidb_server_memory_limit unit description (release-8.0)#23662vjymisal0 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @vjymisal0. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Backport of the master fix (pingcap#23587) to release-8.0: clarify that both 'KiB|MiB|GiB|TiB' and 'KB|MB|GB|TB' unit formats are supported, and add a 90GiB example.
556473d to
179ab1a
Compare
|
Tide reports |
What is changed, added or deleted? (Required)
tidb_server_memory_limitunit description insystem-variables.mdon therelease-8.0branch, matching the wording already fixed onmaster(docs: add memory unit example for tidb_server_memory_limit #23587) and backported torelease-7.5(docs: fix tidb_server_memory_limit unit description #23588) andrelease-8.5(docs: fix tidb_server_memory_limit unit description (release-8.5) #23660).KiB|MiB|GiB|TiBandKB|MB|GB|TBunit formats are supported, and add a90GiBexample.Which TiDB version(s) do your changes apply to? (Required)