Skip to content

docs: fix tidb_server_memory_limit unit description (release-8.4) - #23666

Closed
vjymisal0 wants to merge 1 commit into
pingcap:release-8.4from
vjymisal0:docs/fix-tidb-server-memory-limit-unit-8.4
Closed

docs: fix tidb_server_memory_limit unit description (release-8.4)#23666
vjymisal0 wants to merge 1 commit into
pingcap:release-8.4from
vjymisal0:docs/fix-tidb-server-memory-limit-unit-8.4

Conversation

@vjymisal0

Copy link
Copy Markdown

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • release-8.4

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Aug 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

Hi @vjymisal0. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Aug 29, 2026
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 387211ea-b3de-4aaf-98bb-9c449cf8757f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2026
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Aug 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Backport of the master fix (pingcap#23587) to release-8.4: clarify that both
'KiB|MiB|GiB|TiB' and 'KB|MB|GB|TB' unit formats are supported, and add
a 90GiB example.
@vjymisal0
vjymisal0 force-pushed the docs/fix-tidb-server-memory-limit-unit-8.4 branch from e95c0d6 to 407dfe7 Compare August 29, 2026 07:51
@vjymisal0

Copy link
Copy Markdown
Author

Tide reports Merging to branch release-8.4 is forbidden — this release branch appears to be frozen/EOL for direct merges, independent of review status. Closing this PR since it can't land here; the content fix (matching the already-merged #23587/#23588/#23660) is still valid if a maintainer wants to cherry-pick it via the needs-cherry-pick-release-* bot flow from master instead.

@vjymisal0 vjymisal0 closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant