Repository navigation
Retire standalone Alertmanager and pin initializer base images - #1259
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
fgksgf
left a comment
There was a problem hiding this comment.
LGTM.
Verified:
- No remaining references to the deleted
alertmanager/manifests outside the historicalmonitor/v*directories. busybox:1.37.0@sha256:a7dbc319...matches the current Docker Hub index digest for the tag and includes linux/amd64 and linux/arm64.- Renovate (
config:recommended) will keep the pinned digest updated.
Non-blocking:
reload/Dockerfileandreload/Dockerfile_buildxstill usebusybox:1.37.0without a digest. Out of scope for the initializer, but worth a follow-up if the goal is to pin all base images.- Removing
alertmanager/breaks anyone applying those manifests by raw URL. Consider noting the replacement (TidbMonitor.spec.alertmanagerURLpointing to an externally managed Alertmanager) in the PR description or release notes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgksgf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Summary
TidbMonitor.spec.alertmanagerURL.monitor/as release records.Validation
git diff --check.TestRenderPrometheusConfig*tests to check external Alertmanager configuration and rule generation.editable: falseand that node/pod dashboards and rule files are installed.Summary by CodeRabbit