Repository navigation
Conversation
Windows moves a timed-out toast into Notification Center, and Electron drops clicks on those entries because the notification object is already gone. Keep thread alerts on screen with requireInteraction on Windows so the click still opens the thread.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
vouch:unvouched
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This focused fix makes Windows background thread notifications remain visible until handled, with browser coverage for Windows and non-Windows behavior. Because it changes the default user-facing behavior of Windows system notifications, it requires human review under the applicable policy. You can add or adjust custom eligibility rules. Learn more. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bafedade96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Approval and input alerts can be resolved from another client while this window stays unfocused, so only completions stay on screen.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: keeping Windows thread notifications clickable until handled. |
| Description check | |
The description includes all required sections. It explains the problem, change, scope justification, targeted verification, manual Windows results, and limitations. Screenshots are omitted with an ex… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description includes all required sections. It explains the problem, change, scope justification, targeted verification, manual Windows results, and limitations. Screenshots are omitted with an explicit reason, but the description remains complete and relevant.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
1 participant
Problem
On Windows, clicking a "Thread completed" notification often does nothing: T3 Code doesn't come forward and the thread doesn't open.
This happens when the click lands on an entry in Notification Center rather than on the live banner. Windows moves a toast there after about 7 seconds. At that point Electron fires the web
closeevent and drops its notification object. A later click on the Notification Center entry reaches Electron's toast activator with empty arguments and no live object to dispatch to, so it is discarded and the renderer never getsclick. Every alert you weren't watching when it popped up is a dead entry, and I had around 20 of them stacked under T3 Code (Nightly).Repro (Windows 11, Electron 44.4.5, a minimal app with the same notification options and click handler as
ThreadNotificationCoordinator):Clicking the banner while it is still on screen works.
Change
On Windows, "Thread completed" notifications are now created with
requireInteraction, reusing the existingisWindowsPlatformhelper. Electron then shows the toast as a reminder that stays on screen with a Dismiss button until it is clicked or dismissed, so the click still goes to the live notification and the existing handler opens the thread.Alerts won't pile up while you're in the app: the coordinator already closes pending notifications when the window regains focus, and a newer alert for the same thread replaces the old one by tag. Attention alerts (input, approval, failed, usage limit) keep the normal timeout, because another client can resolve them while this window stays unfocused, and a sticky banner would then advertise an action that no longer exists. Other platforms are unchanged.
Scope and approval
This is a small, focused fix for an obvious bug, so there's no prior issue. It finishes the click-to-open behaviour from #12567, which raised the window on click for #12500 (Linux), for the case where the Windows click never reaches that handler.
The trade-off is that Windows completion alerts now stay on screen until handled instead of timing out. Attention alerts can still lose their click after timing out, since closing them when they're resolved elsewhere needs extra plumbing that would also change the badge count. Fixing clicks on timed-out entries would need Electron-side changes, because the activation carries no data that identifies the thread. Entries that already landed in Notification Center before this change are unaffected.
Verification
vp test run src/components/ThreadNotificationCoordinator.browser.test.tsx src/components/ThreadNotificationCoordinator.badge.browser.test.tsx: 37/37 pass.requireInteraction: true, and a Windows "Input needed" alert getsfalse. Each fails when the matching half of the condition is removed.false.setup()now pinsnavigator.platformso the suite doesn't depend on the host OS.vp lint,vp fmt --checkandtsc --noEmitare clean forapps/web.closefired at about 7s, the banner left the screen, and clicking the Notification Center entry produced noclick.click, which revealed and focused the window.Not checked: a full T3 Code desktop build on Windows. I also left out screenshots because my Notification Center showed unrelated private notifications.
Written by Claude Opus 5.5 (
claude-opus-5-5) in Claude Code, running inside T3 Code. Independently reviewed before filing by GPT-6.1-Sol (gpt-6.1-sol, reasoning effort medium, fast service tier) via a T3 Code delegated task. Verdict: approve after three rounds. Round one flagged that the exact-option tests depended on the host OS. Round three covered the follow-up that keeps attention alerts on the normal timeout. Both are fixed.