Skip to content

Remove fallback because peer will only send TWCC - #448

Open
mengelbart wants to merge 1 commit into
mainfrom
fix/rtpfb-fallback
Open

Remove fallback because peer will only send TWCC#448
mengelbart wants to merge 1 commit into
mainfrom
fix/rtpfb-fallback

Conversation

@mengelbart

Copy link
Copy Markdown
Contributor

The peer negotiated TWCC so this is what is will send us. Falling back to sequence numbers doesn't help here because we won't be able to match the numbers to the incoming TWCC reports. We only push items to the history that will never be used.

Also reduce the logging by logging the warning once instead of repeating it for every packet.

The peer negotiated TWCC so this is what is will send us. Falling back
to sequence numbers doesn't help here because we won't be able to match
the numbers to the incoming TWCC reports. We only push items to the
history that will never be used.

Also reduce the logging by logging the warning once instead of repeating
it for every packet.
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.35%. Comparing base (0e9d5ea) to head (2c2a1a3).

Files with missing lines Patch % Lines
pkg/rtpfb/interceptor.go 12.50% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (12.50%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   81.32%   81.35%   +0.02%     
==========================================
  Files          88       88              
  Lines        4649     4651       +2     
==========================================
+ Hits         3781     3784       +3     
  Misses        689      689              
+ Partials      179      178       -1     
Flag Coverage Δ
go 81.35% <12.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant