Skip to content

Show required updates in parameter listings - #1469

Merged
ayrton merged 1 commit into
mainfrom
adc/parameter-requires-update
Oct 14, 2026
Merged

ayrton merged 1 commit into
mainfrom
adc/parameter-requires-update

Conversation

@ayrton

@ayrton ayrton commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Show when a parameter needs an update before it can be configured in Postgres and Neki parameter listings.

Postgres branch listings and Neki configuration profile, admin, and sidecar listings include a new requires update column. JSON output includes the nullable API field too.

Illustrative examples using standard PostgreSQL parameters. Values and update requirements vary by branch.

Postgres: branch parameters

NAMESPACE  NAME             VALUE  DEFAULT  TYPE     RESTART  REQUIRES UPDATE
pgconf     max_connections  200    100      integer  Yes      Yes
pgconf     work_mem         64MB   4MB      bytes    No       No

If an update is required, run maintenance on the branch:

pscale branch maintenance run <database> <branch> --org <org> --format json

Neki: configuration profile parameters

NAMESPACE  NAME            VALUE  DEFAULT  TYPE   RESTART  REQUIRED  REQUIRES UPDATE
pgconf     shared_buffers  256MB  128MB    bytes  Yes      No        Yes
pgconf     work_mem        64MB   4MB      bytes  No       No        No

If an update is required, run maintenance on the configuration profile:

pscale branch config-profile maintenance <database> <branch> <profile> --org <org> --format json

Security Impact: None

@ayrton
ayrton force-pushed the adc/parameter-requires-update branch from 9cbad1f to 08d0153 Compare October 14, 2026 08:30
@ayrton
ayrton marked this pull request as ready for review October 14, 2026 08:31
@ayrton
ayrton requested a review from a team as a code owner October 14, 2026 08:31

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved. Cursor Bugbot completed with no findings that need human review; Cursor Security Agent was not present. This is a display-only parameter listing change with tests.

Open in Web View Automation 

Sent by Cursor Approval Agent: cli-reviewer

@ayrton
ayrton enabled auto-merge (squash) October 14, 2026 08:43
@ayrton
ayrton force-pushed the adc/parameter-requires-update branch from 08d0153 to 2dff8e5 Compare October 14, 2026 08:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2dff8e5. Configure here.

Comment thread internal/cmd/admin/admin.go
@ayrton
ayrton merged commit 41b7bcf into main Oct 14, 2026
4 checks passed
@ayrton
ayrton deleted the adc/parameter-requires-update branch October 14, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants