Repository navigation
fix: make Ctrl-click link capture opt-in (#69) - #71
Merged
Merged
Conversation
….9.0 The Full and Windows Full manifests no longer declare the markdown-file link handler or the open-link action, so Ctrl-click on file:// Markdown links keeps Herdr's default behavior. The new links/ add-on (annotate-links) declares the handler and runs the installed annotate plugin's plannotator-tui, without a binary of its own. refs #69
backnotprop
force-pushed
the
fix/69-link-capture-opt-in
branch
from
October 7, 2026 16:30
4df6a6a to
7d40597
Compare
The add-on gains an open-link-windows action and markdown-file-windows handler that run links/open-link.ps1, which resolves the annotate plugin root and runs its staged plannotator-tui. The windows-full pane test now drives that action end to end. refs #69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl-click on a
file://Markdown link is no longer captured by Annotate. Herdr matches[[link_handlers]]from the manifest before plugin code runs, so the handler moves out of the Full and Windows Full manifests into a separate opt-in add-on:The add-on (
annotate-links) ships no binary. It looks up theannotateplugin root withherdr plugin list --plugin annotate --jsonand runs that plugin'splannotator-tui herdr openwithHERDR_PLUGIN_ID=annotate, as the oldopen-linkaction did. macOS/Linux useopen-link.sh; Windows (with Windows Full) usesopen-link-windows->open-link.ps1. If Annotate is missing, disabled, or lacks plannotator-tui, it shows a notification saying what to install.Plugin 0.9.0. README notes the change for existing users. Tests: manifest check, Windows PS checks (the windows-full pane test and path matrix now run the add-on's Windows action end to end), smoke.
refs #69