Run every CI job when shared dependency or config files change - #3973
Merged
Conversation
The path filters only listed requirements/** for the background, websocket and streaming jobs, so a dependency-only change skipped the table, dcc, html and backend jobs even though all of them install from those files. The flake8 and mimesis bumps in #3966 passed on the PR and only failed once merged to dev. Add a shared path list (requirements, setup.py, lint and pytest config, root npm manifests, the test harness and this workflow) that every filter includes.
mimesis 12.0.0 claims Python 3.8+ in its metadata but evaluates Locale | str annotations at import time, which fails on 3.9.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3972. The dependabot bump in #3966 went green on its PR because the Table, DCC, HTML and Backend Callback jobs were skipped by the path filters:
requirements/**was only listed for the background, websocket and streaming filters, while every job installs from those files. The flake8 F824 and mimesis Python 3.9 failures only showed up after the merge to dev.This adds a
shared_pathslist that every filter includes (dorny/paths-filter supports YAML anchors for this):requirements/**,setup.pypytest.ini,.flake8,.pylintrcpackage.json,package-lock.jsondash/testing/**(the harness all component tests use).github/workflows/testing.ymlSince this PR touches the workflow file itself, its own run exercises every job.