fix: Keep Cartesian traces aligned with axes after automargin - #7958
Draft
gokul-debugger wants to merge 2 commits into
Draft
fix: Keep Cartesian traces aligned with axes after automargin#7958gokul-debugger wants to merge 2 commits into
gokul-debugger wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7750.
When an automargin-enabled plot title was displayed together with sliders or update menus, the title margin was calculated after the Cartesian plot layer had already been positioned. The axes used the updated margin, but the traces retained the earlier position.
This change draws the title during the existing margin-pusher phase so the title, controls, axes, and traces all use the same final plot dimensions.
A Jasmine regression test reproduces the reported slider and button configuration and verifies that the trace remains aligned with its corresponding y-axis tick.
Testing
npm run pretestnpm run lintnpm run test-syntaxnpm run test-jasmine -- titles --nowatchnpm run test-jasmine -- titles sliders updatemenus plots --nowatchnpm run test-jasmine -- plot_api plot_api_react pie polar ternary geo gl3dlayout --nowatchThe new regression test fails on the unchanged upstream code with a 43.5 px displacement and passes with this fix.
The local Chrome 151 runs also contain existing rendering-tolerance failures. The same failures reproduce on the unchanged upstream branch, and this change introduces no additional failures.