Add missing space in unsupported-marginal error message#5630
Open
eugen-goebel wants to merge 1 commit into
Open
Add missing space in unsupported-marginal error message#5630eugen-goebel wants to merge 1 commit into
eugen-goebel wants to merge 1 commit into
Conversation
Follow-up to plotly#5625. The f-string refactor merged there concatenated two adjacent string literals without a separating space, so the message rendered as "...for `marginal_x`.Supported marginal plot types...". This restores the space after the period.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Follow-up to #5625 (no separate issue).
Description of change
The f-string refactor merged in #5625 concatenated two adjacent string literals without a separating space, so the error message rendered as
...for \marginal_x`.Supported marginal plot types...`. This adds the missing space after the period.Demo
Before:
After:
Testing strategy
Covered by the existing
test_unsupported_marginal_raises_clear_errorintests/test_optional/test_px/test_marginals.py, which still passes. No changelog entry is added because this only polishes the unreleased change from #5625.Guidelines