runtime: fix canonical call context and drop delivery semantics - #375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix spec-confirmed bugs found through the supplementary Wasmtime async corpus, and adopt the operator-authorized drop-delivery correction from component-model PR719.
Real translated regressions cover nested/deferred admission and suspension, after-hop trap cleanup, cancellation while waiting, post-return restrictions and import-edge locality. Drop-delivery tests exercise detached original buffers, exact/partial/zero progress, real wait/poll/cancel/drop paths, and max-count packing. Mutation checks proved the delivery and nested-suspension regressions fail without their fixes.
Coverage delta
Supplementary Wasmtime: 29 formerly failed commands now pass:
New census: 88 files / 850 commands; 544 passed (343 setup,201 assertions),128 classified failures,4 deferred-thread skips,174 excluded commands, zero unexpected outcomes or infrastructure failures. Diagnostic-only mismatches remain classified; no broad message equivalences were added. Related gaps remain tracked by #372.
Official corpus: sync-streams:208 now passes. Removed that exact xfail and adjusted aggregate counts; retained WebKit's independent multi-memory cascade overlay.
Verification
just gates < /dev/nullcompleted across the full run and resumed remaining recipes. Initial lint/type and old test-identity failures were corrected; a later shell run stopped only at the proven stale aggregate count, thenjust shells browsers smoke-tls smoke-c0 < /dev/nullpassed after updating it./tmp/opencode/wasmtime-async-fixes-gates.log,/tmp/opencode/wasmtime-async-fixes-remaining-gates.log.No manifests, protocol marks, or convention goldens changed. Automerge will be armed and watched through delivery.