Repository navigation
ci: run the commit, format, lint, type and knip checks from the shared Checks workflow - #5
Merged
Merged
Conversation
Bundle Stats✅ No significant changes. All scenario measurements (1)🗺️ View treemap · Artifacts
Significant means at least 1.0 KB and 1% gzip, or at least 5 ms and 10% import time. |
christianhg
marked this pull request as draft
November 11, 2026 14:03
christianhg
marked this pull request as ready for review
November 11, 2026 14:15
…d `Checks` workflow The five check workflows move into one `checks` job that calls `checks.yml` in `portabletext/.github`, so the required checks become `checks / commits`, `checks / format`, `checks / lint`, `checks / types` and `checks / knip`. The commit check gains one rule: a commit whose subject is not `fix:` or `feat:` fails when it adds a changeset.
christianhg
force-pushed
the
ci/shared-checks
branch
from
November 11, 2026 14:52
9c35efb to
a2ef229
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a2ef229. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Runs the commit, format, lint, type and knip checks from the shared
checks.ymlworkflow inportabletext/.githubinstead of five local workflows. The steps are the same as before. The commit check gains one rule: a commit whose subject is notfix:orfeat:fails when it adds a changeset. Editing an existing changeset still passes under any type.The required checks get new names, so the "Protect default branch" ruleset needs these replaced when this merges:
check-commitswithchecks / commits,check-formatwithchecks / format,check-lintwithchecks / lint,check-typeswithchecks / types, andcheck-knipwithchecks / knip.Note
Medium Risk
CI and required-check renames depend on the external reusable workflow and manual branch-protection updates; misconfiguration could block merges until rulesets are fixed.
Overview
This PR replaces five repo-local GitHub Actions workflows (
check-commits,check-format,check-lint,check-types,check-knip) with a single Checks workflow that reusesportabletext/.github/.github/workflows/checks.yml@main.Triggers stay aligned with the old setup: pull requests (including
editedfor base retargets) and pushes tomain. The reusable job is givencontents: readandpull-requests: read, matching what the former commit-check workflow needed forgh api.Behavior is intended to stay the same for format, lint, types, and knip; commit/changeset rules move to the shared workflow, including an added rule that commits whose subject is not
fix:/feat:fail when they add a new changeset (editing an existing changeset still passes).Branch protection must be updated after merge: required status check names change from
check-*tochecks / commits,checks / format,checks / lint,checks / types, andchecks / knip.Reviewed by Cursor Bugbot for commit 4af7fa5. Bugbot is set up for automated code reviews on this repo. Configure here.