Skip to content

ci: run the commit, format, lint, type and knip checks from the shared Checks workflow - #5

Merged
christianhg merged 4 commits into
mainfrom
ci/shared-checks
Nov 11, 2026
Merged

christianhg merged 4 commits into
mainfrom
ci/shared-checks

Conversation

@christianhg

@christianhg christianhg commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Runs the commit, format, lint, type and knip checks from the shared checks.yml workflow in portabletext/.github instead of five local workflows. The steps are the same as before. The commit check gains one rule: a commit whose subject is not fix: or feat: fails when it adds a changeset. Editing an existing changeset still passes under any type.

The required checks get new names, so the "Protect default branch" ruleset needs these replaced when this merges: check-commits with checks / commits, check-format with checks / format, check-lint with checks / lint, check-types with checks / types, and check-knip with checks / knip.


Note

Medium Risk
CI and required-check renames depend on the external reusable workflow and manual branch-protection updates; misconfiguration could block merges until rulesets are fixed.

Overview
This PR replaces five repo-local GitHub Actions workflows (check-commits, check-format, check-lint, check-types, check-knip) with a single Checks workflow that reuses portabletext/.github/.github/workflows/checks.yml@main.

Triggers stay aligned with the old setup: pull requests (including edited for base retargets) and pushes to main. The reusable job is given contents: read and pull-requests: read, matching what the former commit-check workflow needed for gh api.

Behavior is intended to stay the same for format, lint, types, and knip; commit/changeset rules move to the shared workflow, including an added rule that commits whose subject is not fix:/feat: fail when they add a new changeset (editing an existing changeset still passes).

Branch protection must be updated after merge: required status check names change from check-* to checks / commits, checks / format, checks / lint, checks / types, and checks / knip.

Reviewed by Cursor Bugbot for commit 4af7fa5. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Bundle Stats

✅ No significant changes.

All scenario measurements (1)

🗺️ View treemap · Artifacts

Scenario Kind Bundle (raw / gzip) Gzip change Import time Import change
⚪ @portabletext/plugin-sdk-value export 242.1 KB / 32.8 KB None None None

Significant means at least 1.0 KB and 1% gzip, or at least 5 ms and 10% import time.

@christianhg
christianhg marked this pull request as draft November 11, 2026 14:03
@christianhg
christianhg marked this pull request as ready for review November 11, 2026 14:15
…d `Checks` workflow

The five check workflows move into one `checks` job that calls
`checks.yml` in `portabletext/.github`, so the required checks become
`checks / commits`, `checks / format`, `checks / lint`,
`checks / types` and `checks / knip`. The commit check gains one rule:
a commit whose subject is not `fix:` or `feat:` fails when it adds a
changeset.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a2ef229. Configure here.

Comment thread .github/workflows/checks.yml Resolved
@christianhg
christianhg merged commit 03cd53d into main Nov 11, 2026
20 checks passed
@christianhg
christianhg deleted the ci/shared-checks branch November 11, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant