Skip to content

ci: probe checks on edited (if) - #7

Closed
christianhg wants to merge 4 commits into
mainfrom
probe/checks-edited-if
Closed

christianhg wants to merge 4 commits into
mainfrom
probe/checks-edited-if

Conversation

@christianhg

@christianhg christianhg commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Throwaway probe of required checks after a PR edit. Closed without merging. (edited)

…d `Checks` workflow

The five check workflows move into one `checks` job that calls
`checks.yml` in `portabletext/.github`, so the required checks become
`checks / commits`, `checks / format`, `checks / lint`,
`checks / types` and `checks / knip`. The commit check gains one rule:
a commit whose subject is not `fix:` or `feat:` fails when it adds a
changeset.
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Bundle Stats

✅ No significant changes.

All scenario measurements (1)

🗺️ View treemap · Artifacts

Scenario Kind Bundle (raw / gzip) Gzip change Import time Import change
⚪ @portabletext/plugin-sdk-value export 242.1 KB / 32.8 KB None None None

Significant means at least 1.0 KB and 1% gzip, or at least 5 ms and 10% import time.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7c213f4. Configure here.

jobs:
checks:
# Base changes alter the commit set that needs checking.
if: github.event.action != 'edited' || github.event.changes.base

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped checks can hide failures

Medium Severity

A title or body edit retriggers this workflow and the job-level if skips checks. GitHub treats skipped jobs as success, so that run can replace a failed required check on the same head SHA and leave a previously red PR mergeable.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7c213f4. Configure here.

@christianhg
christianhg deleted the probe/checks-edited-if branch November 11, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant