Migrate diagnostics setting to positron.r.diagnostics.enabled - #1394
Merged
Conversation
thomasp85
approved these changes
Aug 31, 2026
thomasp85
left a comment
thomasp85
left a comment
Collaborator
There was a problem hiding this comment.
Generally LGTM - at the risk of asking for premature optimisation, might it be better to create a general solution to renaming config entries rather than litter legacy fallbacks around the resolve path that we then need to gradually deprecate? Not a blocker but more an idea to think about
Member
Author
|
That's a great idea for when we've got a few more settings like that! Managing a bunch of migration manually will not be sustainable in the long run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.enablednaming positron#15814This PR migrate the R diagnostics setting from
positron.r.diagnostics.enabletopositron.r.diagnostics.enabled. We'll continue reading and registering the legacy setting for a good long while so existing configurations can still disable diagnostics. This applies the compatibility behavior to both initialization options and liveworkspace/configurationupdates.Testing
Positron Release Notes
New Features
Bug Fixes
positron.r.diagnostics.enabledwhile continuing to honor the legacy setting.