Repository navigation
fix: preserve selector delimiters after escaped backslashes - #354
Open
wozhenbang2004 wants to merge 2 commits into
Open
wozhenbang2004 wants to merge 2 commits into
wozhenbang2004 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class name ends in an escaped backslash, a following
.or#starts a new selector node.splitWord()currently treats every delimiter immediately preceded by a backslash as escaped and merges the nodes.Count consecutive backslashes before the delimiter so an even number leaves it active and an odd number still escapes it. The regression tests exercise both delimiters, escaped delimiters after a backslash, and lossless round trips.
The two new delimiter cases fail on the unmodified parser.
npm testpassed all 905 tests on Node.js 24, including the coverage thresholds.