Repository navigation
Conversation
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
4 times, most recently
from
October 8, 2025 13:34
cfe7ad9 to
4889865
Compare
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
2 times, most recently
from
October 22, 2025 09:07
c6b30de to
9af1a4a
Compare
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
October 27, 2025 09:32
9af1a4a to
15ef06e
Compare
t-sormonte
marked this pull request as ready for review
October 27, 2025 12:59
Contributor
Author
|
Hi @osulzhenko . |
osulzhenko
requested review from
AntoxaAntoxic and
CTMBNara
and removed request for
AntoxaAntoxic
October 31, 2025 09:56
AntoxaAntoxic
suggested changes
Nov 3, 2025
AntoxaAntoxic
left a comment
AntoxaAntoxic
left a comment
Contributor
There was a problem hiding this comment.
Hi, do you have the same PR for the PBS Go? If yes, please link it in the PR
1 task done
Contributor
Author
done |
Contributor
Author
|
Hey @AntoxaAntoxic, |
t-sormonte
force-pushed
the
Sparteo--add-required-query-params-to-adapter-endpoint
branch
from
November 4, 2025 11:14
1dca8a2 to
506fe83
Compare
AntoxaAntoxic
suggested changes
Nov 5, 2025
| } | ||
|
|
||
| @Test | ||
| public void makeHttpRequestsShouldAppendSiteDomainAndNetworkIdAsQueryParams() { |
Contributor
There was a problem hiding this comment.
I meant a test methods order - you've placed tests for makeBids in between the tests for makeHttpRequests
AntoxaAntoxic
suggested changes
Nov 7, 2025
AntoxaAntoxic
previously approved these changes
Nov 14, 2025
CTMBNara
requested changes
Nov 17, 2025
CTMBNara
approved these changes
Nov 18, 2025
riteshghodrao
pushed a commit
to riteshghodrao/prebid-server-java
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We want to support new required query params when calling our SSP
The Go PR: prebid/prebid-server#4556
🧠 Rationale behind the change
Technical integration changes on our side
🔎 New Bid Adapter Checklist
🧪 Test plan
Tested locally and covered by test
🏎 Quality check