Dependencies: Bump Vertx and Spring boot to next major version#4520
Dependencies: Bump Vertx and Spring boot to next major version#4520And1sS wants to merge 9 commits into
Conversation
…er failures with "out of the box" to simplify code.
…ue to case-sensitive headers check.
| @@ -119,19 +118,22 @@ public String name() { | |||
| @Override | |||
| public void initialize(Promise<Void> initializePromise) { | |||
There was a problem hiding this comment.
Vertx switched from promises to futures everywhere in version 5. So maybe for consistency we should update our Initializable interface to work with futures instead of promises too.
| return breaker.execute(promise -> geoLocationService.lookup(ip, timeout).onComplete(promise)); | ||
| } | ||
|
|
||
| private void circuitOpened() { |
There was a problem hiding this comment.
Why did you remove these logs?
| runBlocking(promise -> action.get().onComplete(promise)); | ||
| } | ||
|
|
||
| public <T> void runBlocking(Handler<Promise<T>> action) { |
There was a problem hiding this comment.
Maybe delete the old function and just leave the new one which uses future?
| .collect(Collectors.toMap(Cookie::getName, Cookie::getValue)); | ||
| } | ||
|
|
||
| public static String createCookiesHeader(RoutingContext routingContext) { |
There was a problem hiding this comment.
Do we really need to manually create and add cookie header? When I tested locally, Vertx didn't remove the original cookie header from the request.
There was a problem hiding this comment.
This is a great question, just not in scope of deps bump. If we decide to get rid of this - this will be done in a separate pr.
| assertThat(result.getValue()).usingRecursiveComparison().isEqualTo(expectedResult.getValue()); | ||
|
|
||
| assertThat(result.getValue()).usingRecursiveComparison() | ||
| .withComparatorForType((a, b) -> a.entries().equals(b.entries()) ? 0 : 1, MultiMap.class) |
There was a problem hiding this comment.
Please use .withEqualsForType((a, b) -> a.entries().equals(b.entries()), MultiMap.class) instead of .withComparatorForType. Same in other tests.
| vertx.close(context.succeedingThenComplete()); | ||
| public void tearDown(VertxTestContext context) throws InterruptedException { | ||
| vertx.close().onComplete(context.succeedingThenComplete()); | ||
| context.awaitCompletion(1000, TimeUnit.MILLISECONDS); |
There was a problem hiding this comment.
Not sure if we need context.awaitCompletion. Vertx documentation says that it's called automatically by the VertxExtension.
2 participants
🔧 Type of changes