Port Floxis: New Adapter#4529
Open
floxis-admin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ Whats the context?
This PR ports the Floxis bid adapter from PBS-Go to PBS-Java. Floxis is an ad exchange; the adapter sends standard OpenRTB 2.x server-to-server bid requests to the Floxis exchange so PBS publishers can access Floxis demand. It is the Java counterpart of the in-review Go adapter prebid/prebid-server#4811.
Scope:
appandsite).modifying-vast-xml-allowed: false.🧠 Rationale behind the change
Bidder params (
imp[].ext.prebid.bidder.floxis):seat(string, required, minLength 1) — the Floxis seat the publisher buys through; appended url-escaped to the endpoint as?seat=.region(string, optional, enumus-e/eu/apac, defaultus-e) — selects the regional RTB host.Endpoint routing uses a fixed allowlist map in adapter code (
us-e→rtb-us-e.floxis.tech,eu→rtb-eu.floxis.tech,apac→rtb-apac.floxis.tech; unknown/empty →us-e), filled into the{{Host}}macro. Routing is never derived from a request-supplied hostname — satisfying the "no fully dynamic hostnames" requirement.seat/regionare read from the first imp; the request body is forwarded unchanged (no caller-owned object is mutated).Bid type resolution treats
bid.mtype(OpenRTB 2.6) as authoritative (1/2/3/4 → banner/video/audio/native). Whenmtypeis absent, a single-format imp resolves to that media type; a multi-format imp withoutmtypecannot be disambiguated and surfaces abadServerResponse, while other bids in the response continue to be processed.gvlVendorIDis intentionally omitted (vendor-id: 0) — Floxis is not currently registered in the IAB Global Vendor List.🔎 New Bid Adapter Checklist
🧪 Test plan
FloxisBidderTest— 19 unit tests; JaCoCo reports 100% instruction/line and 95% branch coverage onFloxisBidder. Covers region resolution (us-e/eu/apac/default/unknown/null), url-escaping the seat, request-forwarded-unchanged, and the fullgetMediaTypeForBidmatrix (mtype-authoritative for all four types, unsupported mtype, single-format fallback for all four, multi-format-needs-mtype, no-format, imp-not-found), plus per-bid error accumulation.FloxisTestintegration test — exercises the full auction path against WireMock and validates the adapter configuration is reachable.mvn test(unit + IT) andmvn checkstyle:checkpass locally.🏎 Quality check
Companion Go adapter: prebid/prebid-server#4811. The corresponding
prebid.github.iodocumentation PR is forthcoming.Please add the
do not portlabel per the porting guide (I do not have label permissions on this repo).