Add heat-exchanger-simplified to the system tests#731
Conversation
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-aditya-gupta/2773/2 |
e576056 to
e0727cb
Compare
|
@MakisH plz review! |
MakisH
left a comment
There was a problem hiding this comment.
Thanks for the detailed PR. Some interesting ideas here, but a PR implementing so many ideas at once cannot really be reviewed/merged. I would suggest restricting it to the most important ones that make sense to include as one PR, and delegate the rest to issues and other PRs.
Fine to keep this open for now to discuss which of these ideas would make sense to port to other PRs and how.
43acd04 to
149f4f1
Compare
|
hi @MakisH thanks for the review i will check out everything and reply shortly currently a bit busy with viva in college will surely check out everything by tomorrow |
No hurry, I am the bottleneck here. Good luck with your viva! |
3539239 to
9205670
Compare
9205670 to
f4e5008
Compare
MakisH
left a comment
There was a problem hiding this comment.
Thanks for adding this case! I changed the base branch, since I am bundling such PRs that need new reference results into one.
I opened a few issues regarding the points that were raised from the discussion.
What this PR does
Adds
heat-exchanger-simplifiedto the system test suites intools/tests/tests.yamlas both a new standalone suiteheat_exchanger_simplified_testand as an entry in the existingrelease_testsuite.Also fixes several Docker and Ubuntu 24.04 compatibility issues that prevented local system test runs.
Changes
tests.yaml
heat_exchanger_simplified_teststandalone suite with case(fluid-top-openfoam, fluid-btm-openfoam, solid-calculix)release_testso it runs in release CISystemtest.py
Added_get_docker_compose_cmd()to auto-detectdocker composevsdocker-composeReplaced all 3 hardcodeddocker compose --filePopen calls to use the detection helper with-fDockerfile (ubuntu_2404)
Useduserdel -r ubuntubefore creatingpreciceuser, removing the default Ubuntu 24.04 user including its home directory — cleaner fix for the UID/GID 1000 conflictAdded=masterdefaults for all six adapter ARGs:OPENFOAM_ADAPTER_REF,PYTHON_BINDINGS_REF,FENICS_ADAPTER_REF,CALCULIX_ADAPTER_REF,SU2_ADAPTER_REF,DEALII_ADAPTER_REFAdded--tries=3 --retry-connrefused --timeout=30to wget for both CalculiX and SU2 downloadscomponents.yaml
AddedPYTHON_BINDINGS_REFto calculix-adapter build argsVerification
heat-exchanger-simplifiedhas a completemetadata.yamlwith all required participants and casesmetadata.yamlpython3 print_test_suites.py— bothheat_exchanger_simplified_testandrelease_testshow the new tutorialpython3 systemtests.py --suites=heat_exchanger_simplified_test --build_args=TUTORIALS_REF:develop— Docker images build and coupled run completes; fails only at field-comparison due to missing reference archive (expected)Notes on reference results
Reference results for heat-exchanger-simplified will need to be generated on a Linux machine via CI or
generate_reference_results.py. The.gitkeepplaceholder has been added toheat-exchanger-simplified/reference-results/.Checklist
changelog-entries/731.md