Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The functional change is correct; only minor changelog wording needs attention.
1 open finding
What changed in this PR
Updates the pressure transfer to use consistent mapping, correctly treating pressure as intensive data.
Changes:
- Changes pressure mapping from conservative to consistent.
- Adds a changelog entry.
| File | Description |
|---|---|
free-flow-over-porous-media/precice-config.xml |
Corrects the pressure mapping constraint. |
changelog-entries/944.md |
Documents the fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
The meshes are identical at the interface. |
Fujikawas
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #943 by correctly configuring the mapping of pressure and velocity as consistent mapping.
Note that the system tests are passing, which I would not expect by default for such a case, even if there is some numerical tolerance. Does the mapping actually do something in these meshes, or are they identical at the interface?
Checklist
changelog-entries/<PRnumber>.md.