Conversation
JSON.fast_generate was removed in version 3. It's no longer faster.
kddnewton
approved these changes
Sep 10, 2026
Author
|
Do you understand why CI failing? I don't. |
Author
|
The failing seems to be related to changes between rbs 3 and 4. UPDATE: I have updated the fixtures to what rbs 4 expects. Seems to work with rbs 3 as well. |
Author
|
Hey, @kddnewton. This gem is a central piece of our current pipeline. Having this change would allow us to change from json 2 to 3 in the whole org (https://github.com/ivx). Saying this to tell you that your work is used everyday and is a valuable piece of our system. Thanks for the work. So we are very happy if you find the time to look at this again, but no hurries. |
brerx
added a commit
to ivx/ears
that referenced
this pull request
Sep 18, 2026
Bump Ruby 4.0.6 -> 4.0.7, bundler to 4.0.21, gem dependencies (bunny, rubocop, simplecov, etc). Pin json < 3 in the test group -- 3.0 removed JSON.fast_generate, which @prettier/plugin-ruby's vendored server.rb still calls; remove once prettier/plugin-ruby#1468 ships. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON.fast_generate was removed in version 3. It's no longer faster.
Solves #1467