Modular design system skills and agents for #6789#8113
Draft
joshfarrant wants to merge 4 commits into
Draft
Conversation
Packages up the layer-based modular component agent from #7778 as 8 topic skills scoped to the spectrum of abstraction model from #8012's ADR update (config/presentational/base/utility components), plus an implementer and reviewer agent that reference them. Skills: - modular-ds-spectrum-model (entry point) - modular-ds-config-components - modular-ds-presentational-components - modular-ds-base-components - modular-ds-utilities - modular-ds-accessibility-contract (ported from #7778's dropped accessibility-contract.md, relabeled to the new vocabulary) - modular-ds-decompose-existing-component (from #7778's Mode 2, the workflow #6789 explicitly asks for) - modular-ds-tdd-a11y-test-backfill (net new, not present in either ADR version) No index skill — matches this repo's existing flat skill convention rather than introducing the accessibility-agent-specific skill-list-*.md routing pattern from github-ui. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
|
🤖 Formatting issues have been automatically fixed and committed to this PR. |
…r, port prop-getter shape, note RSC export convention - Entry-points table in the implementer agent now reads as target-state rather than shipped fact (foundations/hooks subpaths don't exist in packages/react/package.json yet). - modular-ds-spectrum-model links to ADR-024, hedged since #8012 (which adds the ADR file) hasn't merged yet. - modular-ds-utilities now shows the prop-getter hook shape in code, not just prose, per the pr-7778 reviewer's ask for concrete patterns. - modular-ds-base-components and modular-ds-presentational-components note that their dot-notation examples are illustrative only; the RSC-safe flat-export convention is what ships. - Implementer agent's validation section now points to modular-ds-tdd-a11y-test-backfill instead of duplicating the 5-step list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Minor follow-up to the review pass -- the sketch called useDialogContext() without showing where the provider that calls useDialog() itself lives. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.