Repository navigation
fix(guide): a room is on the air until its show ends (0.80.3) - #423
Merged
Merged
Conversation
…ts source is a live feed (0.80.3) A podcast mp3 carried as a link channel lists live:false (its SOURCE is not a live feed) the whole time it plays, so its live.streaming room read as offline. The probe now asks whether the channel has ended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan0 finding(s) in the 3 file(s) this pull request changes. Nothing in the files this pull request changes. 56 pre-existing finding(s) elsewhere in the repository — **HIGH**: 17 | **MEDIUM**: 15 | **LOW**: 24Not introduced by this pull request.
…and 36 more; the full set is in the SARIF artifact. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A podcast mp3 carried as a link channel (
POST /api/links/play {live:true}) listslive: falsethe whole time it plays, because a channel'slivesays whether its SOURCE is a live feed. RoomProbe read that as the room being off the air, so a podcast published on live.streaming showed offline. The probe now treats a channel as on the air until it hasended(its outro).Found while wiring auto go-live for TUI Weekly / Off The Record (new @profullstack/golive CLI). Test added in test/guide-rooms.test.ts;
bun test test/guide-rooms.test.tsandtsc --noEmitpass.🤖 Generated with Claude Code