Skip to content

fix(chat): trim participant conversation ids #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Aug 1, 2026
Merged

fix(chat): trim participant conversation ids #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/api/chat/conversations/[id]/participants/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ export async function GET(request, { params } = {}) {
return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
}

const { id: conversationId } = await resolveRouteParams(params);
const { id: rawConversationId } = await resolveRouteParams(params);
const conversationId = typeof rawConversationId === 'string' ? rawConversationId.trim() : '';
if (!conversationId) {
return NextResponse.json({ error: 'Missing conversation ID' }, { status: 400 });
}
Expand Down
21 changes: 21 additions & 0 deletions src/app/api/chat/conversations/[id]/participants/route.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,25 @@ describe('GET /api/chat/conversations/[id]/participants', () => {
expect(body).toEqual({ error: 'Missing conversation ID' });
expect(mocks.authGetUser).toHaveBeenCalled();
});

it('rejects whitespace-only conversation IDs before participant lookup', async () => {
mocks.serviceFrom.mockImplementation((table) => {
if (table === 'users') return createUsersQuery();
if (table === 'conversation_participants') throw new Error('Participant lookup should not run');
throw new Error(`Unexpected table: ${table}`);
});

const { GET } = await import('./route.js');
const response = await GET(
new Request('https://qrypt.chat/api/chat/conversations/%20%20/participants', {
headers: { cookie: 'session=header.payload.signature' }
}),
{ params: Promise.resolve({ id: ' ' }) }
);
const body = await response.json();

expect(response.status).toBe(400);
expect(body).toEqual({ error: 'Missing conversation ID' });
expect(mocks.authGetUser).toHaveBeenCalled();
});
});
Loading