test(desktop): isolate expected TLS error navigation - #112
Merged
Merged
Conversation
ThreatCrush Security Scan56 finding(s) HIGH/CRITICAL: 3 | MEDIUM: 33 | LOW: 20
…and 6 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolate intentionally invalid HTTPS navigations in their own tabs in the same
real Windows browser context. Chromium can finish committing its internal error
page after Playwright's
goto()has already rejected; reusing that tab racesthe next ordinary navigation.
Observed on the post-merge run:
https://github.com/profullstack/tronbrowser.dev/actions/runs/35831711300/attempts/1
The failing step was ordinary
example.comnavigation interrupted bychrome-error://chromewebdata/after the self-signed negative test. Positiveregistry HTTPS, CA import, and exact-root cleanup passed. Final PR #111 CI
had passed the complete same suite before merge.
Safety and Scope
ERR_CERT_AUTHORITY_INVALIDspecifically.