Grant the distribute job the permissions it asks for - #115
Merged
Merged
Conversation
A reusable workflow can only hold a subset of its caller's permissions. submit-packages.yml requests `pull-requests: write` to open the PR carrying the refreshed distribution/ manifests, but release.yml granted only `contents: write`, so the push would succeed and the PR creation be denied. The script also swallowed that denial with a bare `||`, reporting success with no PR behind it. It now distinguishes an already-open PR, which is expected on a re-run, from a real failure, which exits non-zero. A silent success here is precisely how this pipeline spent three months looking healthy while publishing nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
ThreatCrush Security Scan52 finding(s) HIGH/CRITICAL: 3 | MEDIUM: 28 | LOW: 21
…and 2 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reusable workflow can only hold a subset of its caller's permissions.
submit-packages.ymlrequestspull-requests: writeto open the PR carrying the refresheddistribution/manifests, butrelease.ymlgranted onlycontents: write— so the branch push would succeed andgh pr createbe denied.open-distribution-pr.shalso swallowed that denial with a bare||, reporting success with no PR behind it. It now distinguishes an already-open PR (expected on a re-run) from a real failure, which exits non-zero.Follow-up to #114, found before cutting the first release that would have exercised it.
🤖 Generated with Claude Code