Repository navigation
Optimize collection and protobuf value handling - #1018
Merged
Merged
Conversation
Reduce wrapper allocation in collection traversal, membership, and generated protobuf field access. Preserve live list sizes, iterator cursor semantics, custom collection contracts, and dynamic-message fallback. Keep hashes consistent across CEL numeric types, normalize unsigned protobuf fields without sign extension, and preserve Java map equality and extension compatibility. Add collection, iterator, generated-field, and public API regression coverage plus benchmarks.
XN137
reviewed
Oct 27, 2026
Compare map values using Java equality while retaining CEL equality for evaluation. Restrict cross-implementation Java equality to the built-in native and wrapped representations so custom maps can retain identity semantics. Add regressions for unknown expression IDs, hash-based lookup, and symmetric equality with empty and populated custom maps.
XN137
reviewed
Oct 27, 2026
Limit absent-wrapper null substitution to singular fields. Generated getters must retain empty lists for repeated wrappers, matching descriptor access. Cover all nine wrapper types with empty and populated generated and dynamic messages through registry and object getters.
XN137
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce wrapper allocation in collection traversal, membership, and generated protobuf field access. Preserve live list sizes, iterator cursor semantics, custom collection contracts, and dynamic-message fallback.
Keep hashes consistent across CEL numeric types, normalize unsigned protobuf fields without sign extension, and preserve Java map equality and extension compatibility. Add collection, iterator, generated-field, and public API regression coverage plus benchmarks.