(bug) Fix Reloader feature in agentless mode#1832
Merged
Merged
Conversation
gianlucam76
force-pushed
the
reloader
branch
4 times, most recently
from
4438d89 to
f0a6dc6
Compare
In agentless mode all Reloader instances are present in the management cluster. Addon-controller must tell sveltos-agent (also running in the management cluster) which Reloader instances are to be processed for a given cluster. The logic used is same used by event-manager for EventSource instances and healthcheck-manager for HealthCheck instances: updating a per cluster ConfigMap that contains the instance to process. This PR also enhances the reloader test to verify ConfigMap is created in agentless mode and contains the Reloader instance instance name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In agentless mode all Reloader instances are present in the management cluster. Addon-controller must tell sveltos-agent (also running in the management cluster) which Reloader instances are to be processed for a given cluster.
The logic used is same used by event-manager for EventSource instances and healthcheck-manager for HealthCheck instances: updating a per cluster ConfigMap that contains the instance to process.
This PR also enhances the reloader test to verify ConfigMap is created in agentless mode and contains the Reloader instance instance name.