ci: avoid duplicate runs, harden checkout, use rust-cache - #325
Merged
Conversation
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
SuperQ
reviewed
Aug 3, 2026
SuperQ
reviewed
Aug 3, 2026
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on: [push, pull_request]ran every job twice for branches pushed to this repo, which is every dependabot PR, eachdependabot/*branch has a 1 pair ofpushandpull_requestruns per commit.This PR:
pushtomasterandv*, and adds a concurrency group, so superseded pull request runs are cancelled while postsubmit runs onmaster(keyed by SHA) never cancel each other. No required status check depends on thepushevent, and the README badge (?event=push) still resolves, since pushes tomastercontinue to fire.persist-credentials: falseon every checkout and declarespermissions: contents: read. Neither is needed by any step here — nothing pushes, andsetup-protocreceives its token through an explicitrepo-token:input rather than from git config. This matters a little more than usual becausecargo test --all-featuresexecutesbuild.rsfrom every dependency in the tree.actions/cachewithSwatinem/rust-cache. The old key hashedCargo.tomland notCargo.lock, so lockfile-only dependabot PRs restored a cache built from a different dependency set, andtarget/was never cached at all.save-iflimits saving tomasterso pull request branches cannot evict its cache. Pinned toc1937114, thev2.9.1release commit, per this repo's SHA-pin convention.Fork PRs were already unaffected, their
pushfires in the fork, so the duplicate-run fix is not observable on this PR. It will show on the next dependabot PR.