Repository navigation
fix(cpu): handle (null) in /sys/devices/system/cpu/isolated without error - #3860
Open
wangyusheng1985 wants to merge 1 commit into
Open
wangyusheng1985 wants to merge 1 commit into
wangyusheng1985 wants to merge 1 commit into
Conversation
…rror Signed-off-by: yusheng.wang <yusheng.wang@chaitin.com>
SuperQ
requested changes
Oct 20, 2026
| } | ||
|
|
||
| isolcpus, err := sfs.IsolatedCPUs() | ||
| isolcpus, err := getIsolatedCPUs() |
Member
There was a problem hiding this comment.
Do not re-implement procfs functions here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain Linux kernels where no isolated CPUs are configured or the isolated cpumask pointer is null,
/sys/devices/system/cpu/isolatedoutputs(null)(often formatted with leading spaces). Whennode_exporterstarts up, this previously causedstrconv.ParseUint/strconv.Atoito fail withinvalid syntax, panicking the node_exporter process.Treat
(null)as an empty isolated CPU list without returning an error. Add comprehensive unit tests covering empty, null, space-padded null, and standard ranges.Closes #3152
Closes #3310