Repository navigation
Fix mouse-wheel scrolling in radio and checkbox lists - #2163
Open
leeshengis wants to merge 1 commit into
Open
leeshengis wants to merge 1 commit into
leeshengis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1973: this change fixes mouse-wheel scrolling in long radio and checkbox lists. Clicking the scrollbar is not included.
The list's fragment handler consumes wheel events without handling them. Returning
NotImplementedlets the containingWindowscroll, but its cursor-preserving scroll logic also needsmove_cursor_upandmove_cursor_down. The list control now provides those methods, sharing the existing keyboard movement logic and preservingselect_on_focusbehavior.Regression tests dispatch mouse events through rendered handlers and cover both list types, focused and unfocused lists, scroll boundaries, checked-value preservation, click selection after scrolling, and
select_on_focus.Validation on Linux / Python 3.12.14:
git diff --checkpassed.AI assistance was used to investigate the issue, implement the change, and write tests. The diff and test results were also independently reviewed with AI assistance.