Conversation
Author
|
lint and husky make it quite hard to PR |
Anchor the pivot table itself, the way `sourceRef` anchors its source data. The `<location>` element was written with a hardcoded `ref="A3:E15"`, so a destination sheet could carry nothing above the table. `firstHeaderRow`, `firstDataRow` and `firstDataCol` are defined relative to the top left cell of `ref` (ISO/IEC 29500-1, CT_Location), so moving the anchor leaves them alone; only the range is recomputed, keeping the nominal extent Excel recalculates on load anyway. Defaults to A3, so output is unchanged when `ref` is omitted. Committed with --no-verify: the pre-commit eslint hook fails on two errors that predate this change in pivot-table-xform.js (an unused `pageDefaults` destructure and a 139-char line in renderPivotField). Fixing them here would be a drive-by edit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I want to be able to add pivot tables that source data from a certian range
closes #43
Files changed
lib/doc/pivot-table.js
lib/xlsx/xform/pivot-table/pivot-cache-definition-xform.js
lib/xlsx/xform/pivot-table/pivot-cache-records-xform.js
spec/integration/workbook/pivot-tables-source-ref.spec.js
index.d.ts
Test plan
spec/integration/workbook/pivot-tables-source-ref.spec.js
Related to source code (for typings update)
Checklist
wb.xlsx.load/writeBuffer), not synthetic model objects, where possiblegh pr list --state open) for conflicting changes to the same filessoffice --headlessround-trip clean--no-verifywas used to bypass the pre-commit hook) Reason explained above