Repository navigation
Delivery pipeline doctrine: cheap checks before the heavy slot, a settled base after the grant, merged rerun receipts, zero-worker pool alarm - #2169
Merged
Conversation
…tled base after the grant, merged rerun receipts, zero-worker pool alarm Generic delivery-pipeline slowdown patterns, each with one home and an eval case. merge-queue-worktrees.md gets a section next to "A heavy slot guards the contended stage, not the whole train" (unchanged): run the cheap, fast-failing preconditions before queueing for a heavy slot; compose the tested union after the grant, once the previous holder's landing has settled, with the idle wait bounded to one landing and union-dependent build steps inside the grant; end the stage early when the base moves on a path the union touches, which decides only when to abort (landing still needs the proven base). A closing paragraph says what the shipped scripts enforce: train_land.sh waits out a landing train's push lock once, at train start, and land_train.sh only warns on a moved base for a non-split train; the recompose after the grant and the mid-stage compare are doctrine only. pipeline-optimizer.md gets two bullets: a rerun of only the failing tests merges into the original run's receipt on the same tree, with both runs' raw count strings kept beside the merged count, and never replaces it; and a check pool at 0 workers fails silently, so alarm on 0 workers while ready work waits (doctrine only; landing_watchdog.py is its natural home). Mechanism: five cases in agentic-delivery evals.json covering the five rules, prompts that do not state their own answers. Size-budget raises are recorded in changelog.d/pipeline-patterns.md. Tests: agentic-delivery evals.json parses, 301 cases with unique ids; run-evals --selftest ok; test-changelog-fragments 23/23; fragments gate ok; run-ci-tests --affected selected 13 of 294 registered tests, all passed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5 delivery-doctrine rules for the slowdowns a shared heavy slot causes, each with an eval case.
The text says which rules shipped scripts enforce and which are doctrine only. A review's four fix-first items are fixed here.
Verification
Run on this head:
evals.jsonparses (301 cases, unique ids);run-evals.py --selftestok.run-ci-tests.sh --affected: 13 of 294 tests selected, all passed.🤖 Generated with Claude Code