Repository navigation
Landing watchdog: train liveness, decision effect, solo escape past the train marker - #2183
Merged
Merged
Conversation
…he train marker The landing watchdog could say landing was slow but not why. It now reads the train's progress markers from the open PRs plus the newest landing on the default branch, names a train run whose in-flight marker is past 1.5 times its expected time, adds a "No train run in X min" clause to the stall line when the last train activity is an old outcome, and flags a recorded train-size decision that the trains started since it did not carry. green() and train_land.sh's ci_head no longer count the train's own progress marker as a check; in ci_head that was a pre-existing defect that kept the solo re-ride escape from ever firing. train_yield.py records each train's start time, so a decision is judged only on trains that began after it. Tests: affected 23/23 (run-ci-tests --affected against main 9a83ac9), landing_watchdog 94/94, train_yield 16/16, train-solo-port 26/26, changelog fragments 23/23 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landing watchdog now tells a dead train from a slow one: 2 new alarm lines plus a stall-line clause, and the solo re-ride escape fires again. Closes #2166.
What changes
landing_watchdog.py expect 'train_size>=N'records a decision; the hook flags it when 2+ trains begun since carried a smaller median.green()andtrain_land.shci_headignore the train's own marker. Inci_headthis fixes a pre-existing dead solo escape, not a regression.train_yield.py recordstamps each train's start time.Known limits
ghonly.Verification
Tests: affected 23/23 (run-ci-tests --affected against main 9a83ac9), landing_watchdog 94/94, train_yield 16/16, train-solo-port 26/26, changelog fragments 23/23; privacy clean; size-ratchet ok.
🤖 Generated with Claude Code