Repository navigation
Add CanBroker.setFdFrames/isFdFrames, mirroring setLoopback/isLoopback - #132
Merged
Merged
Conversation
cameronkilgore
force-pushed
the
fd-frames-support
branch
from
September 25, 2026 21:00
0692abd to
b233023
Compare
cameronkilgore
force-pushed
the
fd-frames-support
branch
from
September 25, 2026 21:13
b233023 to
32a9c2b
Compare
Owner
|
Would you mind adding a test for this? |
Contributor
Author
Of course, done. Let me know if there's anything else you'd like to see. Thanks |
Owner
|
I think this looks good. Do you need/want a release with this soon or can this wait until I'm back from vacation (mid of October) ? |
Contributor
Author
No rush, it can wait until you're back. Appreciate it! |
Owner
|
thanks! |
Owner
|
I've finally cut the release. |
Contributor
Author
Awesome, hope you enjoyed your vacation. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CanBroker.addDevice applies FILTER and LOOPBACK to every channel it opens, but never CAN_RAW_FD_FRAMES. Without that socket option, the kernel silently drops FD frames on that socket. A device added through CanBroker can't send or receive CAN FD frames.
Adds setFdFrames/isFdFrames, mirroring the existing setLoopback/isLoopback pair exactly, and applies it in addDevice alongside the existing FILTER/LOOPBACK options.