Skip to content

audit: subagent tool lists omit agy 1.4 file tools #23

Closed

Description

@caelaxie

port

agents/poteto-agent.md:5-20 and agents/comment-sicko.md:5-20 both carry this list:

tools:
  - send_message
  - view_file
  - read_url_content
  - search_web
  - schedule
  - generate_image
  - multi_replace_file_content
  - replace_file_content
  - write_to_file
  - run_command
  - manage_task
  - notebook_edit
  - define_subagent
  - invoke_subagent
  - manage_subagents

read_file, write_file, and edit_file are missing. so are grep_search, find_by_name, and list_dir.

upstream

pstack/agents/poteto-agent.md:1-5 and pstack/agents/comment-sicko.md:1-4 have no tools: key, so both subagents get every tool the harness offers (poteto-agent only sets is_background: true).

why agy doesn't require the difference

agy needs a tools list, which is an accepted adaptation, but not a narrower one. #20 established that the agy 1.4+ CLI exposes read_file, write_file, and edit_file instead of view_file / write_to_file / replace_file_content, added them to validAgentTools in .github/workflows/ci.yml:162-184, and updated the skill prose to name both generations. the agent lists were not updated, so on agy 1.4+ CLI these subagents cannot read or edit files, which drops what upstream gives them. grep_search, find_by_name, and list_dir are also allowlisted in CI but absent from both lists.

smallest fix

add read_file, write_file, and edit_file to both tools: lists, keeping the legacy names. also add grep_search, find_by_name, and list_dir so the lists match every name in validAgentTools and the subagents keep upstream's full tool access.

found by the whole-port audit against upstream 88d47514b82e (pstack 0.15.29). fix with Closes #23.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions