Repository navigation
Port upstream pstack #729 - #21
Conversation
Copy cursor/plugins 88d4751 into the agy port and bump the pin to 0.15.29. /sharpen returns only the rewritten prompt. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, same account as author).
checked against upstream 88d4751:
- minimum changes: ok. guide, poteto-help, recipes, and sharpen SKILL.md hunks are verbatim upstream. only divergence is the readme pin and manifest versions, which is required.
- parity: ok. both manifests and readme on
0.15.29, team-kit stays1.2.0. skipping the upstream readme skill-table row andharness/pstack/claude-code/is fine for this repo. - issue linkage: none needed, no open issue for this port.
- harness proof: missing. body says "running". need, at head
63f5e38:agy plugin install+agy plugin listshowing pstack0.15.29, plus/sharpenexercised in a live agy turn (returns only the rewritten prompt, doesn't do the task) or the installed copy ofskills/sharpen/SKILL.mdif the live turn is auth-blocked.
post proof as a comment or in the body and i'll re-review and merge.
harness proof
the cli log reloads slash commands and skills, then print mode fails silent auth and starts oauth. the turn never runs. same for ci on this pr passed: run 39528232517. |
caelaxie
left a comment
There was a problem hiding this comment.
portreview re-review at 63f5e38108b88087c0150d9ab5d722e28f935781. verdict: not approved yet, not merging.
holds:
- head unchanged since the last review.
skills/sharpen/SKILL.mdat head is byte-identical to upstream cursor/plugins88d4751(#729). - ci: run 39528232517 /
Validate pluginis success on this head sha. agy plugin install(branch url) +agy plugin listshow pstack(enabled, 0.15.29), 59 skills, 2 agents.
gaps in the harness proof (the comment shows prose or abridged output where the bar needs real command output):
- installed rev: only
git log -1 --oneline→63f5e38(short). need the full sha from the installed copy, e.g.git -C "$AGY_HOME/.gemini/config/plugins/pstack" rev-parse HEADprinting63f5e38108b88087c0150d9ab5d722e28f935781. - installed sharpen: the installed
skills/sharpen/SKILL.mdis only described in prose. paste real output, e.g.catof the installed file, ordiffof it against upstreampstack/skills/sharpen/SKILL.mdat88d4751showing no difference. - auth error: the
/sharpenattempt output is elided with.... paste the full verbatim output of the realagy --print="/sharpen ..."attempt (redact only the oauth url/token, and mark the redaction as such).
per the agy #19 precedent, an auth-blocked live turn is fine once 1-3 are real output. post them as a comment on this head and i'll re-review and merge.
|
Dropped the OAuth |
caelaxie
left a comment
There was a problem hiding this comment.
portreview: approved on 63f5e38.
all three asks from my 09:40 review are in #21 (comment) as real command output:
- installed sha:
git rev-parse HEADon the installed plugin =63f5e38108b88087c0150d9ab5d722e28f935781(exit 0). - installed
skills/sharpen/SKILL.md:catmatches the head's file in this diff, andcmpanddiff -uagainstgit show 63f5e38…:skills/sharpen/SKILL.mdboth exit 0. - live
/sharpen:agy --print '/sharpen …'exits 1 with the full auth error (login url, 60s wait,Error: authentication timed out./error: authentication failed or timed out). only the oauthstateparam is redacted, which is fine. auth-block fallback accepted per precedent.
diff matches upstream cursor/plugins 88d4751 (#729), agy plugin list shows 0.15.29, CI run 39528232517 (Validate plugin) is green on this head. nit, non-blocking: the comment shows agy 1.4.2 and the PR body says 1.4.3.
squash-merging pinned to the head sha.
summary
ports upstream cursor/plugins
88d4751(#729) onto0.15.28. bumps the pin to0.15.29. cursor-team-kit stays1.2.0.git log d45756733..origin/main -- pstack/is exactly this one commit. nothing else underpstack/after0.15.28is missing.ported
#72988d47514brestore/sharpento the original prompt, return only the rewrite, bump to0.15.29skills/sharpen/SKILL.md, the guide paragraphs, the poteto-help row, and the recipe line are the upstream text. files this port already adapts keep those adaptations (install paths, model tiers,invoke_subagentworkspaces, bundled/deslop,/goalinstead of/loop, agy 1.4+ file tool names).antigravity-only adaptations
0.15.29inplugin.jsonand.antigravity-plugin/plugin.json. the agy manifest keeps its existing shape (logo,suggestedPrompts). rootplugin.jsonkeeps the pstack-ports homepage and repository.0.15.29. upstreampstack/README.mdskill-table row for/sharpenis not copied. this readme is the antigravity install page and does not carry that table.harness/pstack/claude-code/copies of the same edits are not in this repo.skipped
2b8ae2ee3(2026-09-08), author field only oncursor-team-kit/.cursor-plugin/plugin.json. no skill changes. still1.2.0./sharpenmodel turn.agy --printstops at google oauth. this environment is not signed in.harness proof
agy1.4.3, installed from the antigravity cli installer. commands ran against this branch with a cleanHOME.agy plugin list --jsonlistssharpen. installed version is0.15.29. the installedskills/sharpen/SKILL.mdmatches this branch: description "Make a task deeper, not bigger, then rewrite the prompt.", the four numbered asks, "Then rewrite my prompt to ask for exactly that.", and "Leave choices that are mine to make open instead of deciding them." it does not contain "then do the work".the cli log reloads slash commands and skills, then print mode fails silent auth and starts oauth. the turn never runs. same for
--print="/skills".the ci workflow on this pr passed: run 39528232517.
agy1.4.3,Validated 59 skills, 2 agents, and 23 playbooks., 69 pass / 0 fail.