Repository navigation
port upstream pstack through 0.15.29 - #14
Conversation
synced to 88d4751. version is 0.15.29 in plugin.json, .devin-plugin/plugin.json, and the readme marker. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: request changes (posting as comment, same account).
- minimum changes: ok. all 8 files match upstream 88d4751 (#729) verbatim apart from the
/pstack:prefix anddisable-model-invocation: true->triggers: [user]. - parity: ok. version 0.15.29 in plugin.json, .devin-plugin/plugin.json, readme. skips (claude-code harness tree, .cursor-plugin, readme catalog row) are fine. no other pstack/ changes through 190d287.
- ci: validate plugin green.
- issue linkage: none needed.
- harness proof: missing. need a comment showing
devin plugins install(a--localinstall pinned to the full head sha 5a47394 is fine) +devin plugins listshowing pstack 0.15.29, plus/pstack:sharpenexercised, or if the live turn is auth-blocked, the installed copy of skills/sharpen/SKILL.md from that install. symlink-only proof won't do.
will merge once the proof lands.
harness proofReal Devin CLI on a local box (no cloud agent, no git clone). PR head
1–3. before list, install, after list4–7. installed cache copy (a real file, not a symlink)8. vs upstream 88d4751The only differences are the Note on "only the rewrite": neither the upstream skill nor this port contains that literal phrase. What was restored is the original prompt: four analysis points, then 9. live /pstack:sharpenThe output has the four sections the skill asks for, followed by the rewritten prompt. It does not attempt the task: no code, no edits, just one Afterwards, the scratch dir contains only |
caelaxie
left a comment
There was a problem hiding this comment.
verdict: approved (posting as comment, same account).
- head: unchanged at 5a47394, so the earlier diff check against upstream 88d4751 (#729) still holds.
- harness proof (issuecomment-6305788887): ok. the
--localwrapper's requiredPlugins pins pstack-ports/devin-pstack to the full head sha, and devin fetched it into its own cache.devin plugins listshowspstack v0.15.29 (required). the installed skills/sharpen/SKILL.md is a regular file in the plugin cache, not a symlink, and is cmp-identical to the head. i checked its content against raw @ head and it matches. a live/pstack:sharpenturn injected the skill body and returned the four-point analysis plus a rewritten prompt, with no edits. - ci: validate plugin green on the head.
squash-merging pinned to the head sha.
synced to
88d4751. comparedd457567..mainforpstack/; later commits on upstreammainthrough190d287do not touchpstack/. version is0.15.29inplugin.json,.devin-plugin/plugin.json, and the readme marker.ported:
88d4751(#729) restore/sharpento the original prompt and return only the rewrite. the four asks are a numbered list. guide pages 2 and 10, poteto-help, and recipes match. slash commands keep the/pstack:prefix.disable-model-invocation: truestaystriggers: [user]. the version bumps to0.15.29. the same bump is in.devin-plugin/plugin.jsonand the readme marker, which is where this repo records the version.skipped:
harness/pstack/claude-code/copies in #729. this port does not carry the generated claude code tree.pstack/.cursor-plugin/plugin.json. cursor packaging. the version bump lands in.devin-plugin/plugin.jsoninstead./sharpen. this port's readme is a pointer, not a copy of the upstream catalog. the version marker is bumped. the skill is indexed in poteto-help, the guide, and recipes.harness proof (install,
devin plugins list, exercising/pstack:sharpen) will follow as a comment. the devin cli can't log in from this cloud environment.