Repository navigation
search binary sessions.db in worktree-audit - #25
Conversation
Add -a to the rg call so the SQLite session store is not skipped as a binary file. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
harness proofHead One-row SQLite file ripgrep 14.1.1 (the version named in #24) and ripgrep 15.1.0-cursor5 both do this when searching the directory: With a sibling Local CI steps on this head: plugin validation (56 skills, 2 agents, 23 playbooks), |
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (proof only). posting as a comment since github blocks request-changes on own-account prs.
- minimum changes: pass. the diff is exactly #24's smallest fix, one
-aon L107, nothing else touched. - layout/target: pass.
- parity: pass, no version or upstream text drift.
- linkage: pass,
Closes #24. - harness proof: missing.
Validate pluginis green at31d9333, but devin ci only doesbash -n+ bun tests and says itself thatdevin plugins install/listcan't run there. this is a script behavior change, so ci isn't enough.
needed, at head 31d9333742746205ec33139a19497454ab374303:
devin plugins install --localpinned to that full sha (devin fetches the repo itself; symlink proofs don't count) +devin plugins listshowing pstack.- behavior proof: run the installed
worktree-audit.sh(or its rg line) against a devin cli dir whosesessions.dbholds a worktree path, and show LAST_CHAT / the rg hit now comes fromsessions.db(before vs after is ideal, like the repro in #24).
post it as a pr comment or in the body and i'll merge.
| last="-"; last_ts=0 | ||
| if [ -d "$transcripts" ]; then | ||
| f=$(rg -l -e "${wt}/" -e "${wt}\"" "$transcripts" 2>/dev/null \ | ||
| f=$(rg -l -a -e "${wt}/" -e "${wt}\"" "$transcripts" 2>/dev/null \ |
There was a problem hiding this comment.
matches #24's fix. just need proof this line now hits sessions.db from the installed copy.
harness proofReal Devin CLI on a local box (no cloud agent, no git clone). PR head
1–3. before list, install, after list4–5. installed cache copy6–7. L107's rg call, built the way the script builds it
With
|
caelaxie
left a comment
There was a problem hiding this comment.
re-review at 31d9333: lgtm. diff is only the -a on L107 from #24's smallest fix. proof shows a --local wrapper pinned to the full head sha, pstack v0.15.29 (required) in devin plugins list, the installed script cmp-identical to head, and L107 hitting sessions.db (with no hit without -a). closes #24, not a draft, Validate plugin green. the gnu stat -f/date -r issue is out of scope and is an upstream follow-up. merging.
Closes #24
Add
-ato thergcall inskills/poteto-mode/scripts/worktree-audit.shso it searches the binarysessions.dbstore.