Repository navigation
Point skill authoring at the playbook, not loops it lacks - #22
Merged
Merged
Conversation
Factory /create-skill is a user pane, not an agent skill with YAML rules, writing guidelines, or a description-optimization loop. Callers keep the authoring playbook and the frontmatter rules that exist, and stop citing the loops that do not. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
commented
Oct 21, 2026
caelaxie
left a comment
Contributor
Author
There was a problem hiding this comment.
verdict: pass, merging.
- minimum changes: 4/4 lines, takes #10's fallback branch. the factory docs answer (
/create-skillis a user slash command with a spec-mode pane, no agent-callable yaml/writing/loop surface) is stated in the body, so dropping the playbook "YAML rules", "writing guidelines", draft/test/iterate and description-optimization citations is the right cut. nothing else touched. - layout/target: no cursor paths or shims added.
- parity: unchanged otherwise; the true references (playbook step 1, poteto-mode pointer,
new skill:, 09-make-it-yours) stay. - proof:
Validate plugingreen on 409fdb0. droid ci doesmarketplace add pstack-ports/droid-pstack#<branch>+plugin install+plugin list+ skill frontmatter checks, accepted for a text-only skill fix (agy #30 precedent). - linkage:
Closes #10. not a draft.
|
Harness proof. Command output is unedited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Can an agent invoke
/create-skillthe way upstream invokes Cursor'screate-skillskill, and does it have a YAML-rules / writing-guidelines / description-optimization surface?No. Factory's skills docs describe
/create-skillas a user slash command. In the CLI it opens a Create Skill pane; in the Factory App it opens a wizard. It forks the session into Spec mode, researches the workflow, and writes files only after the user approves. It is not a skill an agent or subagent can hand work to, and the docs do not describe a YAML-rules, writing-guidelines, draft/test/iterate, or description-optimization surface.Callers therefore stay pointed at the authoring playbook and at Droid's real frontmatter rules (
descriptionis one YAML scalar). This PR only drops the citations of loops and named sections the playbook does not contain:automate-meno longer says the playbook has "YAML rules" or "writing guidelines". The scalar rules stay. Prose edits point at the playbook's prose rules.reflectno longer says to run a draft/test/iterate loop or a description-optimization loop.Left as they are, because they name something that exists:
nameanddescription, lowercase-hyphen directory name, supporting files besideSKILL.md)poteto-mode's pointer at that playbook for agent-facing prosenew skill:inreflectand the synthesizer, rather thannew skill via create-skill:docs/guide/09-make-it-yours.md, which already routes through the playbook and its frontmatter check