Skip to content

Recognize only factory-droid[bot] as the automated reviewer - #25

Merged
caelaxie merged 1 commit into
mainfrom
cursor/watch-pr-factory-droid-9106
Oct 21, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/watch-pr-factory-droid-9106

Conversation

@caelaxie

Copy link
Copy Markdown
Contributor

Closes #12

Do droid auto review and droid-review come from droid-action's example workflow?

Yes. Factory-AI/droid-action's droid-review.yml example is named Droid Auto Review, and the job id is droid-review. The README also says the Factory Droid GitHub App posts as factory-droid[bot]. Those two tokens stay in AUTOMATION_TOKENS as the substitute for bugbot. security review stays as well; the same example turns on automatic_security_review.

isBugbot now returns true only for author === "factory-droid[bot]" (the login is lowercased first). The bugbot substring and the any-login-containing-droid match are gone, and so are the two port comments. The bugbot logins in github.test.ts are factory-droid[bot]. The isBugbot / bugbotReviewPasses names are unchanged. CURSOR_AUTOMATION_ID stays dropped; pass keys are still RUN_ID only.

Open in Web Open in Cursor 

Bugbot and any login containing "droid" are no longer the reviewer. Pass keys stay RUN_ID-only, and the droid-action check names stay in the automation token list.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: pass, merging.

  • minimum changes: diff is exactly #12's smallest fix. isBugbot returns author === "factory-droid[bot]", both port comments gone, test logins at L247/L277 swapped, identifiers and AUTOMATION_TOKENS untouched.
  • layout/target: no cursor shims left in watch-pr (bugbot substring and CURSOR_AUTOMATION_ID both out).
  • parity: rest of the file still matches upstream 88d4751 apart from the existing droid substitution.
  • proof: Validate plugin green at 629b196. that job runs droid plugin marketplace add pstack-ports/droid-pstack#<head branch>, droid plugin install, droid plugin list, typecheck, and bun run test, so the changed tests ran.
  • linkage: Closes #12. not a draft.

@caelaxie
caelaxie merged commit b63cf69 into main Oct 21, 2026
1 check passed
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Harness proof. Command output is unedited.

HOME=/tmp/droid-proof-watch-pr
which=/tmp/droid-proof-watch-pr/.local/bin/droid
0.245.0
===== droid plugin marketplace add =====
Successfully added marketplace: droid-pstack@cursor-watch-pr-factory-droid-9106
===== droid plugin install =====
Successfully installed pstack@droid-pstack@cursor-watch-pr-factory-droid-9106 (629b196)
===== droid plugin list =====
Installed plugins:
Active:
  pstack@droid-pstack@cursor-watch-pr-factory-droid-9106  [user]  629b196
$ git -C /tmp/droid-proof-watch-pr/.factory/plugins/cache/droid-pstack@cursor-watch-pr-factory-droid-9106-4c04f92907f4/pstack-7171b73fae68/629b1960f76e rev-parse HEAD
629b1960f76e356500ba93f70492333744f9afe9
(exit 0)
$ echo expected
629b1960f76e356500ba93f70492333744f9afe9
$ git -C /workspace diff --name-status 3a60c3580a01bba100804e6efe3395d9f5dd924e cursor/watch-pr-factory-droid-9106
M	skills/poteto-mode/scripts/watch-pr/github.test.ts
M	skills/poteto-mode/scripts/watch-pr/github.ts
(exit 0)
MATCH skills/poteto-mode/scripts/watch-pr/github.test.ts
MATCH skills/poteto-mode/scripts/watch-pr/github.ts
===== droid exec =====
Skill "poteto-mode" activated
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: watch-pr still matches bugbot and any "droid" login

2 participants