Repository navigation
Recognize only factory-droid[bot] as the automated reviewer - #25
Merged
Merged
Conversation
Bugbot and any login containing "droid" are no longer the reviewer. Pass keys stay RUN_ID-only, and the droid-action check names stay in the automation token list. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
commented
Oct 21, 2026
caelaxie
left a comment
Contributor
Author
There was a problem hiding this comment.
verdict: pass, merging.
- minimum changes: diff is exactly #12's smallest fix.
isBugbotreturnsauthor === "factory-droid[bot]", both port comments gone, test logins at L247/L277 swapped, identifiers andAUTOMATION_TOKENSuntouched. - layout/target: no cursor shims left in watch-pr (
bugbotsubstring andCURSOR_AUTOMATION_IDboth out). - parity: rest of the file still matches upstream 88d4751 apart from the existing droid substitution.
- proof:
Validate plugingreen at 629b196. that job runsdroid plugin marketplace add pstack-ports/droid-pstack#<head branch>,droid plugin install,droid plugin list, typecheck, andbun run test, so the changed tests ran. - linkage:
Closes #12. not a draft.
|
Harness proof. Command output is unedited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Do
droid auto reviewanddroid-reviewcome from droid-action's example workflow?Yes. Factory-AI/droid-action's
droid-review.ymlexample is namedDroid Auto Review, and the job id isdroid-review. The README also says the Factory Droid GitHub App posts asfactory-droid[bot]. Those two tokens stay inAUTOMATION_TOKENSas the substitute forbugbot.security reviewstays as well; the same example turns onautomatic_security_review.isBugbotnow returns true only forauthor === "factory-droid[bot]"(the login is lowercased first). Thebugbotsubstring and the any-login-containing-droidmatch are gone, and so are the two port comments. Thebugbotlogins ingithub.test.tsarefactory-droid[bot]. TheisBugbot/bugbotReviewPassesnames are unchanged.CURSOR_AUTOMATION_IDstays dropped; pass keys are stillRUN_IDonly.