Repository navigation
port pstack 0.15.28 (#716, #721, #724) - #7
Conversation
Bring in upstream formal-verification upkeep: TLA+ as the default model checker, a no-verifier fallback, the new maintain-formal-verification-skill, and the 0.15.28 guide sync. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, same account as author).
diff is clean. checked against upstream d4575673 (still pstack head):
create-formal-verification-skill,maintain-formal-verification-skill,poteto-help/references/recipes.md: byte-identical to upstream.poteto-help/SKILL.md, guide 06, guide 09: only the pre-existing grok adaptations differ; new upstream lines land verbatim, including the 09 anchor fix.plugin.json+ README at 0.15.28, matches upstream.cursor-plugin/plugin.json. cursor-team-kit stays 1.2.0, no upstream commits since.- validate plugin: green. no open issue to link, so no Closes/Refs needed.
blocking: harness proof is "pending". need, on head 6574fb4:
grok plugin install <path> --trustandgrok plugin listshowing pstack 0.15.28.- changed skills exercised:
maintain-formal-verification-skillpresent and loadable in the installed copy, plus the new create-formal-verification-skill and poteto-help text visible there. a live/maintain-formal-verification-skillturn if auth allows; if only cli auth blocks it, install+list plus inspect/installed-copy output is enough for this text-only change.
add it to the body or as a comment and i'll merge.
|
Harness proof for head
Installed path: create-formal-verification-skill ( poteto-help new lines, from the installed copy.
A model turn did not run. |
caelaxie
left a comment
There was a problem hiding this comment.
portreview: approved at 6574fb4.
The harness proof in #7 (comment) (grok 1.0.62) closes the earlier gap:
grok plugin install …@cursor/port-pstack-0.15.28-e85e --trustinstalled pstackgrok plugin list --jsonandgrok plugin details pstackshow pstack 0.15.28- the installed checkout
rev-parse HEADis6574fb4e491c15da161f3c6931be194cd2df1aa5, which is the PR head grok inspectloadscreate-formal-verification-skill,maintain-formal-verification-skillandpoteto-helpfrom plugin pstack (userInvocable: true), and the installed text includes the TLA+ default, the no-verifier fallback, and the new poteto-help and recipes lines- no live turn ran because the CLI is not signed in. As in #5 and #6, inspect loading the changed skills counts as exercise.
Content was already checked against upstream d4575673. Validate plugin passed on 6574fb4. Squash-merging now, pinned to 6574fb4.
Port upstream
pstack/fromf9be7aa0(#715) throughd4575673(#724). Version goes from 0.15.27 to 0.15.28. cursor-team-kit stays 1.2.0. The short port README only changes the version.Upstream commits
Verified with
git log f9be7aa0..main -- pstack cursor-team-kiton https://github.com/cursor/plugins:6b78e9f4/ #721 — fix(pstack): TLA+ default and no-verifier fallback in create-formal-verification-skill7b353f78/ #716 — add maintain-formal-verification-skill (new skill, plus edits to create-formal-verification-skill, poteto-help, guide verify-and-ship section and guide page 9)d4575673/ #724 — bump to 0.15.28, sync guide page 6 with create-formal-verification-skillcursor-team-kit/has no commits afterf9be7aa0. No.cursor-plugin/plugin.json(same as earlier port PRs). README skill-table lines from upstream are not applied. This port's README has no skill table.Grok adaptations
New upstream text is copied verbatim, except:
plugin.jsonis bumped to0.15.28. Upstream's.cursor-plugin/plugin.jsonbump is not copied. This port has no Cursor plugin manifest.0.15.28.Touched files already carried these adaptations, and this port leaves them in place:
docs/guide/06-verify-and-ship.mdkeeps.grok/skills/verify-<app>/where upstream says.cursor/skills/verify-<app>/.docs/guide/09-make-it-yours.mdkeeps.grok/skills/<your-name>-mode/SKILL.mdand Grok Build's/create-skillwhere upstream says.cursorand Cursor's built-increate-skill.skills/poteto-help/SKILL.mdkeeps the existing Grok Build paragraph in place of upstream's "Other tools can read the skills… spawn Cursor subagents…" paragraph. The Claude Code install paragraph stays, becausedocs/harness/claude-code.mdis already in this port. Existing wording stays:~/.grok/rules/pstack-models.md,spawn_subagent,subagent_type: "pstack:poteto-agent",isolation: "worktree", bundleddeslop/control-cli/control-ui, and no custom mode.skills/create-formal-verification-skill/SKILL.md,skills/maintain-formal-verification-skill/SKILL.md, andskills/poteto-help/references/recipes.mdmatch upstream. The new skill has no.cursorpaths and no spawn wording to adapt.CI
Validate plugin succeeded on
6574fb4. It reportedValidated 59 skills, 2 agents, and 23 playbooksandRan 68 tests across 5 files.Harness proof
grok 1.0.62, on
cursor/port-pstack-0.15.28-e85eat6574fb4e491c15da161f3c6931be194cd2df1aa5. Full output: #7 (comment)grok inspectloadscreate-formal-verification-skillandmaintain-formal-verification-skillfrom that plugin (userInvocable: true). The installedcreate-formal-verification-skillsays TLA+ is the default for a bad order of events in any language, and if no verifier runs on the language, say so and test the real code with generated inputs. The installed poteto-help lines mention/maintain-formal-verification-skillwhen covered code changed after the recorded sync commit, in the skill table, and inreferences/recipes.md.A model turn did not run.
grok -p '/maintain-formal-verification-skill' --max-turns 1 --cwd /tmp --verbatimexited 1: not signed in, andXAI_API_KEYis unset.